From 2be17f6aaa30fe927a410eed2bcca6717cf6f766 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Fri, 10 Feb 2017 21:19:11 +0000 Subject: repogit: add prototypes for error checking And add a note to remove git_commit_title --- lib/PublicInbox/RepoGit.pm | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/PublicInbox/RepoGit.pm b/lib/PublicInbox/RepoGit.pm index f7bf0b9d..b44457ca 100644 --- a/lib/PublicInbox/RepoGit.pm +++ b/lib/PublicInbox/RepoGit.pm @@ -19,7 +19,7 @@ my %GIT_ESC = ( v => "\013", ); -sub git_unquote { +sub git_unquote ($) { my ($s) = @_; return $s unless ($s =~ /\A"(.*)"\z/); $s = $1; @@ -28,7 +28,8 @@ sub git_unquote { $s; } -sub git_commit_title { +# Remove, hilariously slow +sub git_commit_title ($$) { my ($git, $obj) = @_; # PublicInbox::Git, $sha1hex my $rv; eval { @@ -39,7 +40,7 @@ sub git_commit_title { } # example inputs: "HEAD -> master", "tag: v1.0.0", -sub git_dec_links { +sub git_dec_links ($$) { my ($rel, $D) = @_; my @l; foreach (split /, /, $D) { -- cgit v1.2.3-24-ge0c7