diff options
author | Eric Wong <e@80x24.org> | 2017-01-26 04:27:02 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2017-01-26 07:55:23 +0000 |
commit | c3288fb27efcca73ba87e27c2c2b41b4a1dfbd46 (patch) | |
tree | a4afdc4f8aefc341ad5bbc6c5f7495592e6183c0 /lib/PublicInbox/RepobrowseGitSnapshot.pm | |
parent | 9877e27be55f7a8d00a613630875d647d97d7bb3 (diff) | |
download | public-inbox-c3288fb27efcca73ba87e27c2c2b41b4a1dfbd46.tar.gz |
This shortens the code quite a bit at a negligible performance cost, and the diffstat agrees.
Diffstat (limited to 'lib/PublicInbox/RepobrowseGitSnapshot.pm')
-rw-r--r-- | lib/PublicInbox/RepobrowseGitSnapshot.pm | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/lib/PublicInbox/RepobrowseGitSnapshot.pm b/lib/PublicInbox/RepobrowseGitSnapshot.pm index a9751b97..450fdad6 100644 --- a/lib/PublicInbox/RepobrowseGitSnapshot.pm +++ b/lib/PublicInbox/RepobrowseGitSnapshot.pm @@ -65,8 +65,8 @@ sub call_git_snapshot ($$) { # invoked by PublicInbox::RepobrowseBase::call delete $env->{'repobrowse.tree_cb'}; delete $env->{'qspawn.quiet'}; my $pfx = "$repo_info->{snapshot_pfx}-$ref/"; - my $cmd = [ 'git', "--git-dir=$git->{git_dir}", 'archive', - "--prefix=$pfx", "--format=$fmt", $tree ]; + my $cmd = $git->cmd('archive', + "--prefix=$pfx", "--format=$fmt", $tree); my $rdr = { 2 => $git->err_begin }; my $qsp = PublicInbox::Qspawn->new($cmd, undef, $rdr); $qsp->psgi_return($env, undef, sub { @@ -80,8 +80,7 @@ sub call_git_snapshot ($$) { # invoked by PublicInbox::RepobrowseBase::call }); }; - my @cmd = ('git', "--git-dir=$git->{git_dir}", - qw(rev-parse --verify --revs-only)); + my $cmd = $git->cmd(qw(rev-parse --verify --revs-only)); # try prefixing "v" or "V" for tag names to get the tree my @refs = ("V$ref", "v$ref", $ref); $env->{'qspawn.quiet'} = 1; @@ -98,7 +97,7 @@ sub call_git_snapshot ($$) { # invoked by PublicInbox::RepobrowseBase::call } my $rdr = { 2 => $git->err_begin }; my $r = pop @refs; - my $qsp = PublicInbox::Qspawn->new([@cmd, $r], undef, $rdr); + my $qsp = PublicInbox::Qspawn->new([@$cmd, $r], undef, $rdr); $qsp->psgi_qx($env, undef, $env->{'repobrowse.tree_cb'}); }; sub { |