diff options
author | Eric Wong <e@80x24.org> | 2017-02-15 22:35:18 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2017-02-16 04:27:50 +0000 |
commit | f6244586ba4f5a5e7575e1254be8c9bbe303fce9 (patch) | |
tree | d1a8dd757b632f8cff66e3878f7cfc01e6e2f12d /lib/PublicInbox/RepoGitDiff.pm | |
parent | 993dc7a772b10deda15733c8e750d98bf4d27bd0 (diff) | |
download | public-inbox-f6244586ba4f5a5e7575e1254be8c9bbe303fce9.tar.gz |
Query strings make endpoint caching more difficult since they're order-independent. They are also more likely lost or truncated inadvertantly when copy+pasting, so try to avoid them for default endpoints. There's still some things which are broken and followup commits will be needed to fix them.
Diffstat (limited to 'lib/PublicInbox/RepoGitDiff.pm')
-rw-r--r-- | lib/PublicInbox/RepoGitDiff.pm | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/PublicInbox/RepoGitDiff.pm b/lib/PublicInbox/RepoGitDiff.pm index bb71e738..ef4717ac 100644 --- a/lib/PublicInbox/RepoGitDiff.pm +++ b/lib/PublicInbox/RepoGitDiff.pm @@ -34,11 +34,8 @@ sub git_diff_sed ($$) { sub call_git_diff { my ($self, $req) = @_; + my ($id, $id2) = split(/\.\./, $req->{h}); my $env = $req->{env}; - my $q = PublicInbox::RepoGitQuery->new($env); - my $id = $q->{id}; - my $id2 = $q->{id2}; - my $git = $req->{repo_info}->{git}; my $cmd = $git->cmd(qw(diff-tree -z --numstat -p --encoding=UTF-8 --no-color -M -B -D -r), $id2, $id, '--'); |