about summary refs log tree commit homepage
path: root/lib/PublicInbox/RepoGitBlob.pm
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2017-02-15 22:35:18 +0000
committerEric Wong <e@80x24.org>2017-02-16 04:27:50 +0000
commitf6244586ba4f5a5e7575e1254be8c9bbe303fce9 (patch)
treed1a8dd757b632f8cff66e3878f7cfc01e6e2f12d /lib/PublicInbox/RepoGitBlob.pm
parent993dc7a772b10deda15733c8e750d98bf4d27bd0 (diff)
downloadpublic-inbox-f6244586ba4f5a5e7575e1254be8c9bbe303fce9.tar.gz
Query strings make endpoint caching more difficult since
they're order-independent.  They are also more likely lost
or truncated inadvertantly when copy+pasting, so try to
avoid them for default endpoints.

There's still some things which are broken and followup
commits will be needed to fix them.
Diffstat (limited to 'lib/PublicInbox/RepoGitBlob.pm')
-rw-r--r--lib/PublicInbox/RepoGitBlob.pm5
1 files changed, 1 insertions, 4 deletions
diff --git a/lib/PublicInbox/RepoGitBlob.pm b/lib/PublicInbox/RepoGitBlob.pm
index 586b4acc..f9c28c22 100644
--- a/lib/PublicInbox/RepoGitBlob.pm
+++ b/lib/PublicInbox/RepoGitBlob.pm
@@ -12,10 +12,7 @@ our @EXPORT = qw(git_blob_mime_type git_blob_stream_response);
 sub call_git_blob {
         my ($self, $req) = @_;
         my $git = $req->{repo_info}->{git};
-        my $q = PublicInbox::RepoGitQuery->new($req->{env});
-        my $id = $q->{id};
-        $id eq '' and $id = 'HEAD';
-        $id .= ":$req->{expath}";
+        my $id = $req->{-tip} . ':' . $req->{expath};
 
         my ($cat, $hex, $type, $size) = $git->cat_file_begin($id);
         return unless defined $cat;