diff options
| author | Eric Wong <e@yhbt.net> | 2020-04-18 03:38:53 +0000 |
|---|---|---|
| committer | Eric Wong <e@yhbt.net> | 2020-04-19 08:51:29 +0000 |
| commit | 0c586dc64b3b6642a894e125d09df446667a4079 (patch) | |
| tree | 38d6b349b64e6395e1910aaae2ef450b06d96a13 /lib/PublicInbox/Mbox.pm | |
| parent | 92de3139920992bfad32ef927153f27addfdc72c (diff) | |
| download | public-inbox-0c586dc64b3b6642a894e125d09df446667a4079.tar.gz | |
It's unnecessary overhead for anything which does Email::MIME parsing. It was never done for v2 indexing, even though v1->v2 conversions did NOT remove those From_ lines. There was never a need to remote From_ lines the v1 SearchIdx paths, either. Hitting a /$INBOX_URL/$MSGID/T/ endpoint with an 18 message thread reveals a ~0.5% speed improvement. This will become more apparent when we have a faster MIME parser.
Diffstat (limited to 'lib/PublicInbox/Mbox.pm')
| -rw-r--r-- | lib/PublicInbox/Mbox.pm | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/lib/PublicInbox/Mbox.pm b/lib/PublicInbox/Mbox.pm index 16de1a72..9995140c 100644 --- a/lib/PublicInbox/Mbox.pm +++ b/lib/PublicInbox/Mbox.pm @@ -106,8 +106,11 @@ sub msg_hdr ($$;$) { 'List-Post', "<mailto:$ibx->{-primary_address}>", ); my $crlf = $header_obj->crlf; - my $buf = 'From mboxrd@z Thu Jan 1 00:00:00 1970' . $crlf . - $header_obj->as_string; + my $buf = $header_obj->as_string; + # fixup old bug from import (pre-a0c07cba0e5d8b6a) + $buf =~ s/\A[\r\n]*From [^\r\n]*\r?\n//s; + $buf = "From mboxrd\@z Thu Jan 1 00:00:00 1970" . $crlf . $buf; + for (my $i = 0; $i < @append; $i += 2) { my $k = $append[$i]; my $v = $append[$i + 1]; |