diff options
author | Eric Wong <e@80x24.org> | 2023-01-31 00:05:15 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2023-01-31 00:27:06 +0000 |
commit | 0746680da02f51ff3f85ebde1a3e9219d0946cf0 (patch) | |
tree | 2ddbdb85c5047bb80c7be19767a40a8ba4b0d4d4 | |
parent | 5dbb060037ce3e3a3ba0812baa90c80eeee762af (diff) | |
download | public-inbox-0746680da02f51ff3f85ebde1a3e9219d0946cf0.tar.gz |
I noticed these while tracking down circular refs for commit 7b654d175cf2e31b (ipc: drop awaitpid_init to avoid circular refs, 2023-01-30). While they're not the cause of circular refs, they're still a waste of memory in worker processes.
-rw-r--r-- | lib/PublicInbox/LEI.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/LEI.pm b/lib/PublicInbox/LEI.pm index ffd50db5..d05b20de 100644 --- a/lib/PublicInbox/LEI.pm +++ b/lib/PublicInbox/LEI.pm @@ -561,17 +561,17 @@ sub note_sigpipe { # triggers sigpipe_handler sub _lei_atfork_child { my ($self, $persist) = @_; # we need to explicitly close things which are on stack + my $cfg = $self->{cfg}; if ($persist) { open $self->{3}, '<', '/' or die "open(/) $!"; fchdir($self); close($_) for (grep(defined, delete @$self{qw(0 1 2 sock)})); - if (my $cfg = $self->{cfg}) { - delete @$cfg{qw(-lei_store -watches -lei_note_event)}; - } + delete @$cfg{qw(-lei_store -watches -lei_note_event)}; } else { # worker, Net::NNTP (Net::Cmd) uses STDERR directly open STDERR, '+>&='.fileno($self->{2}) or warn "open $!"; STDERR->autoflush(1); POSIX::setpgid(0, $$) // die "setpgid(0, $$): $!"; + delete @$cfg{qw(-watches -lei_note_event)}; } close($_) for (grep(defined, delete @$self{qw(old_1 au_done)})); delete $self->{-socks}; |