diff: note the dangers of gigantic anchors hash

1 files changed, 2 insertions, 0 deletions

diff --git a/lib/PublicInbox/RepobrowseGitDiffCommon.pm b/lib/PublicInbox/RepobrowseGitDiffCommon.pm
index ac38aa0a..ae0e6821 100644
--- a/lib/PublicInbox/RepobrowseGitDiffCommon.pm
+++ b/lib/PublicInbox/RepobrowseGitDiffCommon.pm
@@ -240,6 +240,8 @@ sub git_diff_sed_stat ($$) {
                 $l =~ /\A(\S+)\t+(\S+)\t+(.*)/ or next;
                 my ($add, $del, $fn) = ($1, $2, $3);
                 if ($fn ne '') { # normal modification
+                        # TODO: discard diffs if they are too big
+                        # gigantic changes with many files may still OOM us
                         my $anchor = to_attr(git_unquote($fn));
                         $req->{anchors}->{$anchor} = $fn;
                         $l = utf8_html($fn);