diff options
author | Eric Wong <e@80x24.org> | 2019-02-24 02:55:40 +0000 |
---|---|---|
committer | Eric Wong <e@80x24.org> | 2019-04-04 09:13:58 +0000 |
commit | 293c51d2c23ceb8b8018cf4bfa3deaf56f7753b2 (patch) | |
tree | 9ed8de2607fcdb5b952feb77623a572c81a08dcb | |
parent | 4123a89e08e145405fa781be7f4590c4d13f4138 (diff) | |
download | public-inbox-293c51d2c23ceb8b8018cf4bfa3deaf56f7753b2.tar.gz |
No need to scan the entire string, but prefer to match git behavior. This might be faster if/when Perl can create substrings efficiently using CoW. Fix a 80-column violation while we're at it.
-rw-r--r-- | lib/PublicInbox/ViewVCS.pm | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/lib/PublicInbox/ViewVCS.pm b/lib/PublicInbox/ViewVCS.pm index b41adc44..962dc66b 100644 --- a/lib/PublicInbox/ViewVCS.pm +++ b/lib/PublicInbox/ViewVCS.pm @@ -135,14 +135,14 @@ sub solve_result { return html_page($ctx, 500, \$log); } - my $binary = index($$blob, "\0") >= 0; + my $bin = index(substr($$blob, 0, $BIN_DETECT), "\0") >= 0; if (defined $fn) { my $h = [ 'Content-Length', $size, 'Content-Type' ]; - push(@$h, ($binary ? 'application/octet-stream' : 'text/plain')); + push(@$h, ($bin ? 'application/octet-stream' : 'text/plain')); return delete($ctx->{-wcb})->([200, $h, [ $$blob ]]); } - if ($binary) { + if ($bin) { $log = "<pre>$oid $type $size bytes (binary)" . " $raw_link</pre>" . $log; return html_page($ctx, 200, \$log); |