about summary refs log tree commit
diff options
context:
space:
mode:
authorSteve Hay <steve.m.hay@googlemail.com>2014-11-20 13:30:52 +0000
committerSteve Hay <steve.m.hay@googlemail.com>2014-11-20 13:30:52 +0000
commit2a65863a5cc0c42497e8da41e6d77fb770891057 (patch)
tree6b8c00eee720921e1085c9ce1a2aed3f25c0745e
parentc2fe21c50ceb473ceb80f1343948d9a172aec59d (diff)
downloadperl-libnet-2a65863a5cc0c42497e8da41e6d77fb770891057.tar.gz
Increased minimum required Socket version from 1.3 to 2.016
This turned out to be the cause of the remaining problem on CPAN RT#100020,
but only on machines having IO::Socket::IP (and even then that worked fine
on my machine, so it is probably OS dependent).

Don't restate the minimum required version everywhere that Socket is used.
It seems like overkill (and maintenance hassle) in a world where various
CPAN shells do a good job of installing required versions of prerequisite
modules, and it already wasn't done for IO::Socket (which also has a minimum
required version).
-rw-r--r--Changes7
-rw-r--r--Makefile.PL2
-rw-r--r--lib/Net/FTP.pm2
-rw-r--r--lib/Net/SMTP.pm2
4 files changed, 10 insertions, 3 deletions
diff --git a/Changes b/Changes
index dc7a98c..04d8dea 100644
--- a/Changes
+++ b/Changes
@@ -2,6 +2,13 @@ Revision history for Perl distribution libnet
 
 3.03 Development
 
+    - Increased minimum required Socket version from 1.3 to 2.016.  This may be
+      required when those modules that can support IPv6 load IO::Socket::IP (on
+      some OSes, at least).  It does not appear to be necessary if they load
+      IO::Socket::INET6 or IO::Socket::INET instead, but this is not easy for
+      the end-user to control so it is simpler to always insist on Socket 2.016
+      or higher.  [CPAN RT#100020]
+
     - Fixed "Argument ... isn't numeric in subroutine entry" warnings when using
       older versions of Perl.  [CPAN RT#100020]
 
diff --git a/Makefile.PL b/Makefile.PL
index 215f566..81e8ed8 100644
--- a/Makefile.PL
+++ b/Makefile.PL
@@ -188,7 +188,7 @@ MAIN: {
             'IO::Select'     => '0',
             'IO::Socket'     => '1.05',
             'POSIX'          => '0',
-            'Socket'         => '1.3',
+            'Socket'         => '2.016',
             'Symbol'         => '0',
             'Time::Local'    => '0',
             'constant'       => '0',
diff --git a/lib/Net/FTP.pm b/lib/Net/FTP.pm
index 8808685..4a3f309 100644
--- a/lib/Net/FTP.pm
+++ b/lib/Net/FTP.pm
@@ -21,7 +21,7 @@ use Fcntl qw(O_WRONLY O_RDONLY O_APPEND O_CREAT O_TRUNC);
 use IO::Socket;
 use Net::Cmd;
 use Net::Config;
-use Socket 1.3;
+use Socket;
 use Time::Local;
 
 our $VERSION = '3.03';
diff --git a/lib/Net/SMTP.pm b/lib/Net/SMTP.pm
index 1348831..58d74ff 100644
--- a/lib/Net/SMTP.pm
+++ b/lib/Net/SMTP.pm
@@ -18,7 +18,7 @@ use Carp;
 use IO::Socket;
 use Net::Cmd;
 use Net::Config;
-use Socket 1.3;
+use Socket;
 
 our $VERSION = "3.03";