diff options
author | Steve Hay <steve.m.hay@googlemail.com> | 2014-12-20 12:51:04 +0000 |
---|---|---|
committer | Steve Hay <steve.m.hay@googlemail.com> | 2014-12-20 12:51:04 +0000 |
commit | 4953a0fc9e74bae849344e60b77df72c018f598e (patch) | |
tree | 50b8a9ffa69d8965078068b7ae1091bd4b07393e | |
parent | 56e5ec7a786f0a0b5c95f017285b8b9791de068a (diff) | |
download | perl-libnet-4953a0fc9e74bae849344e60b77df72c018f598e.tar.gz |
No need for the "1" at the end of "eval { require XXX; 1 }"
The module should return a true value anyway; require will die if that isn't the case.
-rw-r--r-- | t/config.t | 4 | ||||
-rw-r--r-- | t/datasend.t | 4 | ||||
-rw-r--r-- | t/ftp.t | 4 | ||||
-rw-r--r-- | t/hostname.t | 4 | ||||
-rw-r--r-- | t/netrc.t | 4 | ||||
-rw-r--r-- | t/nntp.t | 4 | ||||
-rw-r--r-- | t/require.t | 4 | ||||
-rw-r--r-- | t/smtp.t | 4 | ||||
-rw-r--r-- | t/time.t | 4 |
9 files changed, 18 insertions, 18 deletions
@@ -6,12 +6,12 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } undef *{Socket::inet_aton}; undef *{Socket::inet_ntoa}; - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } $INC{'Socket.pm'} = 1; diff --git a/t/datasend.t b/t/datasend.t index cdbdc29..3a97c4b 100644 --- a/t/datasend.t +++ b/t/datasend.t @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # Skip: no Socket module\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # Skip: EBCDIC but no Convert::EBCDIC\n"; exit 0; } } diff --git a/t/hostname.t b/t/hostname.t index 25f1cda..55031bf 100644 --- a/t/hostname.t +++ b/t/hostname.t @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } diff --git a/t/require.t b/t/require.t index a48951a..70ec1f6 100644 --- a/t/require.t +++ b/t/require.t @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } } @@ -6,10 +6,10 @@ use strict; use warnings; BEGIN { - if (!eval { require Socket; 1 }) { + if (!eval { require Socket }) { print "1..0 # no Socket\n"; exit 0; } - if (ord('A') == 193 && !eval { require Convert::EBCDIC; 1 }) { + if (ord('A') == 193 && !eval { require Convert::EBCDIC }) { print "1..0 # EBCDIC but no Convert::EBCDIC\n"; exit 0; } $INC{'IO/Socket.pm'} = 1; |