From f978d2071407399c783a045c30dba7823ea45ec5 Mon Sep 17 00:00:00 2001 From: Eric Wong Date: Thu, 28 Jul 2016 01:59:34 +0000 Subject: _tail: do not mutate existing arrays We need to ensure we have a consistent data structure across pages. --- lib/oldweb/_tail.rhtml | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/lib/oldweb/_tail.rhtml b/lib/oldweb/_tail.rhtml index 4320fc2..14fc5a8 100644 --- a/lib/oldweb/_tail.rhtml +++ b/lib/oldweb/_tail.rhtml @@ -1,8 +1,8 @@ <% public_email = @old_cfg['public_email'] private_email = @old_cfg['private_email'] -source_code = Array(@old_cfg['source_code']) -archive_urls = Array(@old_cfg['ml_url']).concat(Array(@old_cfg['nntp_url'])) +source_code = Array(@old_cfg['source_code']).dup +archive_urls = Array(@old_cfg['ml_url']) + Array(@old_cfg['nntp_url']) if url = archive_urls.shift %>
 mail archives: <%= url %><%
@@ -20,11 +20,10 @@ href="mailto:<%= public_email %>"><%= public_email %><%
 href="mailto:<%= private_email %>"><%= private_email %><%
     end
   end
-end
 
 if url_or_cmd = source_code.shift
 %>
 source code: <%= url_or_cmd %>
 <% source_code.each do |x| %><%= "\t#{x}" %><% end
 end
-%>
+%><% end %> -- cgit v1.2.3-24-ge0c7