olddoc user/dev discussion/patches/bugs/etc
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: <olddoc-public@80x24.org>
Subject: [PATCH] oldweb: use native String#encode for (X)HTML escaping
Date: Tue, 24 Jan 2017 23:28:11 +0000	[thread overview]
Message-ID: <20170124232811.32157-1-e@80x24.org> (raw)

This allows us to avoid loading the 'cgi' library.
---
 lib/oldweb.rb | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/lib/oldweb.rb b/lib/oldweb.rb
index b1b7c46..910afaf 100644
--- a/lib/oldweb.rb
+++ b/lib/oldweb.rb
@@ -5,7 +5,6 @@ require 'rdoc'
 require 'erb'
 require 'pathname'
 require 'yaml'
-require 'cgi'
 require 'uri'
 
 # oldweb is an \RDoc template and not intended as a programming API.
@@ -288,7 +287,7 @@ class Oldweb
   # reach into RDoc internals to generate less HTML
   module LessHtml # :nodoc:
     def accept_verbatim(verbatim)
-      @res << "\n<pre>#{CGI.escapeHTML(verbatim.text.rstrip)}</pre>\n"
+      @res << "\n<pre>#{verbatim.text.rstrip.encode(xml: :text)}</pre>\n"
     end
 
     def accept_heading(heading)
-- 
EW


                 reply	other threads:[~2017-01-24 23:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/olddoc/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170124232811.32157-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=olddoc-public@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/olddoc.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).