about summary refs log tree commit homepage
diff options
context:
space:
mode:
authorEric Wong <e@80x24.org>2018-08-11 04:04:42 +0000
committerEric Wong <e@80x24.org>2018-08-11 04:07:56 +0000
commitf2155aca16e5786a1d1189d5eb10458111b78014 (patch)
tree2c2db8378df2ef8aeb10011cd10d4fd62eeb23c7
parenta58386266d4effd90efa840fb0b7d6aa5ce71748 (diff)
downloadmwrap-f2155aca16e5786a1d1189d5eb10458111b78014.tar.gz
Mwrap.total_bytes_allocated/total_bytes_freed API needs docs,
and we need to clarify heap page stats are not reset.
-rw-r--r--ext/mwrap/mwrap.c10
1 files changed, 10 insertions, 0 deletions
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index cbda436..2ee04a5 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -1193,11 +1193,17 @@ static VALUE mwrap_quiet(VALUE mod)
         return rb_ensure(rb_yield, SIZET2NUM(cur), reset_locating, 0);
 }
 
+/*
+ * total bytes allocated as tracked by mwrap
+ */
 static VALUE total_inc(VALUE mod)
 {
         return SIZET2NUM(total_bytes_inc);
 }
 
+/*
+ * total bytes freed as tracked by mwrap
+ */
 static VALUE total_dec(VALUE mod)
 {
         return SIZET2NUM(total_bytes_dec);
@@ -1338,6 +1344,10 @@ void Init_mwrap(void)
          * from posix_memalign(3) use in mainline Ruby:
          *
          *   https://sourceware.org/bugzilla/show_bug.cgi?id=14581
+         *
+         * These statistics are never reset by Mwrap.reset or
+         * any other method.  They only make sense in the context
+         * of an entire program lifetime.
          */
         hpb = rb_define_class_under(mod, "HeapPageBody", rb_cObject);
         rb_define_singleton_method(hpb, "stat", hpb_stat, -1);