From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <e@80x24.org>
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on dcvr.yhbt.net
X-Spam-Level: 
X-Spam-ASN:  
X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no
	autolearn=ham autolearn_force=no version=3.4.6
Received: from localhost (dcvr.yhbt.net [127.0.0.1])
	by dcvr.yhbt.net (Postfix) with ESMTP id 96F971F47C
	for <mwrap-public@80x24.org>; Mon,  9 Jan 2023 07:01:42 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org;
	s=selector1; t=1673247702;
	bh=UhZX25cZTpit0Wkr12y/OMWEWcYui0HuTgR4YsvzfpU=;
	h=From:To:Subject:Date:From;
	b=1XiXlGsVEaJe0RZQEVn5p0AzC5yOsIcoantnFkdvRbuDOImJftI2pgoJsV9bkFE/x
	 m9RAugfh8O8FpqCFsQ17js7Md6MwZOfX0lXj7nsLUpXlqZgaPYjopLfcOQCqm4mQHu
	 ZuJJQPFs7jdOOZb4IcTS71cfqkCYAxV+fNe0aOzA=
From: Eric Wong <e@80x24.org>
To: <mwrap-public@80x24.org>
Subject: [PATCH] fix test_sigusr1_works
Date: Mon,  9 Jan 2023 07:01:42 +0000
Message-Id: <20230109070142.10654-1-e@80x24.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
List-Id: <mwrap-public.80x24.org>

`p' will deadlock even with `STDOUT.sync=true', apparently :<
---
 test/test_mwrap.rb | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)

diff --git a/test/test_mwrap.rb b/test/test_mwrap.rb
index e04fab5..58c9743 100644
--- a/test/test_mwrap.rb
+++ b/test/test_mwrap.rb
@@ -126,33 +126,41 @@ class TestMwrap < Test::Unit::TestCase
 
   # some URCU flavors use USR1, ensure the one we choose does not
   def test_sigusr1_works
+    err = Tempfile.new('dump')
     cmd = @@cmd + %w(
       -e STDOUT.sync=true
-      -e trap(:USR1){p("HELLO_WORLD")}
+      -e trap(:USR1){STDOUT.syswrite("HELLO_WORLD\n")}
       -e END{Mwrap.dump}
-      -e puts -e STDIN.read)
+      -e puts("HI")
+      -e STDIN.read)
     IO.pipe do |r, w|
       IO.pipe do |r2, w2|
-        pid = spawn(@@env, *cmd, in: r2, out: w, err: '/dev/null')
+        pid = spawn(@@env, *cmd, in: r2, out: w, err: err)
         r2.close
         w.close
-        assert_equal "\n", r.gets
+        assert_equal "HI\n", r.gets, '#puts HI fired'
         buf = +''
         10.times { Process.kill(:USR1, pid) }
-        while r.wait_readable(0.1)
+        Thread.pass # sched_yield
+        while r.wait_readable(0.5)
           case tmp = r.read_nonblock(1000, exception: false)
-          when String
-            buf << tmp
-          when nil
-            break
+          when String; buf << tmp; break
+          when nil; break
+          else
+            warn "Unexpected read_nonblock result: #{tmp.inspect}"
           end
         end
-        w2.close
-        Process.wait(pid)
-        assert_predicate $?, :success?, $?.inspect
-        assert_equal(["\"HELLO_WORLD\"\n"], buf.split(/^/).uniq)
+        w2.close # break from STDERR.read
+        _, st = Process.wait2(pid)
+        warn "# buf=#{buf.inspect}" if $DEBUG
+        assert_predicate(st, :success?,
+          "#{st.inspect} is success buf=#{buf.inspect} "\
+          "err=#{err.rewind;err.read.inspect}")
+        assert_equal(["HELLO_WORLD\n"], buf.split(/^/).uniq)
       end
     end
+  ensure
+    err.close! if err
   end
 
   def test_reset