mwrap user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: <mwrap-public@80x24.org>
Subject: [PATCH] test_mwrap: fix test reliability
Date: Sun,  8 Jan 2023 21:40:52 +0000	[thread overview]
Message-ID: <20230108214052.27246-1-e@80x24.org> (raw)

Not sure what drugs I was on when I wrote this :x
---
 test/test_mwrap.rb | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/test/test_mwrap.rb b/test/test_mwrap.rb
index 29bbdd2..176dca6 100644
--- a/test/test_mwrap.rb
+++ b/test/test_mwrap.rb
@@ -5,6 +5,7 @@ require 'test/unit'
 require 'mwrap'
 require 'rbconfig'
 require 'tempfile'
+require 'io/wait'
 
 class TestMwrap < Test::Unit::TestCase
   RB = "#{RbConfig::CONFIG['bindir']}/#{RbConfig::CONFIG['RUBY_INSTALL_NAME']}"
@@ -128,10 +129,12 @@ class TestMwrap < Test::Unit::TestCase
         assert_equal "\n", r.gets
         buf = +''
         10.times { Process.kill(:USR1, pid) }
-        while IO.select([r], nil, nil, 0.1)
+        while r.wait_readable(0.1)
           case tmp = r.read_nonblock(1000, exception: false)
           when String
             buf << tmp
+          when nil
+            break
           end
         end
         w2.close

                 reply	other threads:[~2023-01-08 21:40 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/mwrap/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230108214052.27246-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-public@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).