From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Subject: [PATCH 2/2] paranoid safety fix to clamp pathnames to PATH_MAX
Date: Sat, 3 Sep 2022 11:20:20 +0000 [thread overview]
Message-ID: <20220903112020.2317141-3-e@80x24.org> (raw)
In-Reply-To: <20220903112020.2317141-1-e@80x24.org>
While I doubt Ruby (nor Perl) would store pathnames longer than
PATH_MAX by default, it's possible `eval' users to specify
whatever path (and line number) they wish to use.
Likely was the case with `# line $FILE' directives in Perl5
which prompted this clamping.
---
ext/mwrap/mwrap.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index 90f560e..08761d6 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -470,6 +470,8 @@ static struct src_loc *update_stats_rcu_lock(size_t size, uintptr_t caller)
/* avoid vsnprintf or anything which could call malloc here: */
len = strlen(ptr);
+ if (len > PATH_MAX)
+ len = PATH_MAX;
k = (void *)kbuf;
k->total = size;
dst = mempcpy(k->k, ptr, len);
prev parent reply other threads:[~2022-09-03 11:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 11:20 [PATCH 0/2] various safety fixes from the Perl side Eric Wong
2022-09-03 11:20 ` [PATCH 1/2] Ractor compatibility Eric Wong
2022-09-03 11:20 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903112020.2317141-3-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).