From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.2 required=3.0 tests=ALL_TRUSTED,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, T_SCC_BODY_TEXT_LINE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 0F0651F54E; Sat, 20 Aug 2022 23:18:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1661037526; bh=PQ090QcEOHATPmwBH52gD8sdn3qPpG2LIpKQpyazU8c=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NZS4+Gpp3f8pzzyYmBznwP6sDKg1KfFR9LcgXsEfquu/Unh2tUY7+7G9C9EyMM8dz RZQU0eio9m+ABYV4yK1YJrmtfooyIrLO4QfblEsXt877BJtDm1ondLktoQvFxsg/EH zrN97YGy2nJK/spLTqUHJ2t1jIBkFAK/0RzYX+yU= Date: Sat, 20 Aug 2022 23:18:04 +0000 From: Eric Wong To: mwrap-public@80x24.org Cc: Sam Saffron Subject: Re: [PATCH 3/3] disable HeapPageBody count test for Ruby 3.1 Message-ID: <20220820231804.M449261@dcvr> References: <20220820213523.18504-1-e@80x24.org> <20220820213523.18504-4-e@80x24.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20220820213523.18504-4-e@80x24.org> List-Id: Eric Wong wrote: > Ruby 3.1+ uses mmap on platforms relevant to us, so we currently > can't account for it with various malloc wrappers. > > Tested on Ruby 3.1.2, this is the only change necessary to > support 3.1.x so far; but the functionality is gone unless > we decide to wrap mmap, as well. I should note that wrapping mmap probably isn't worth it. My original reason for tracking heap_page_body was specifically to track problems related to memalign itself (at least as far as glibc goes). Using mmap neatly sidesteps the problems of (glibc) memalign: https://80x24.org/mwrap-public/20180810064943.24287-1-e@80x24.org/