From: Eric Wong <e@80x24.org>
To: <mwrap-public@80x24.org>
Cc: Sam Saffron <sam.saffron@gmail.com>
Subject: [PATCH 3/3] disable HeapPageBody count test for Ruby 3.1
Date: Sat, 20 Aug 2022 21:35:23 +0000 [thread overview]
Message-ID: <20220820213523.18504-4-e@80x24.org> (raw)
In-Reply-To: <20220820213523.18504-1-e@80x24.org>
Ruby 3.1+ uses mmap on platforms relevant to us, so we currently
can't account for it with various malloc wrappers.
Tested on Ruby 3.1.2, this is the only change necessary to
support 3.1.x so far; but the functionality is gone unless
we decide to wrap mmap, as well.
---
test/test_mwrap.rb | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/test/test_mwrap.rb b/test/test_mwrap.rb
index fadaef6..c506554 100644
--- a/test/test_mwrap.rb
+++ b/test/test_mwrap.rb
@@ -309,7 +309,9 @@ class TestMwrap < Test::Unit::TestCase
gen <= GC.count && gen >= 0 or abort "bad generation: #{gen}"
(0 == (addr & 16383)) or abort "addr not aligned: #{'%x' % addr}"
end
- nr == ap or abort "HeapPageBody.each missed page #{nr} != #{ap}"
+ if RUBY_VERSION.to_f < 3.1 # 3.1+ uses mmap on platforms we care about
+ nr == ap or abort "HeapPageBody.each missed page #{nr} != #{ap}"
+ end
10.times { (1..20000).to_a.map(&:to_s) }
3.times { GC.start }
Mwrap::HeapPageBody.stat(h)
next prev parent reply other threads:[~2022-08-20 21:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-20 21:35 [PATCH 0/3] Ruby 3.x support Eric Wong
2022-08-20 21:35 ` [PATCH 1/3] constify arg for totals_add_rcu Eric Wong
2022-08-20 21:35 ` [PATCH 2/3] support Ruby 3.0.x Eric Wong
2022-08-20 21:35 ` Eric Wong [this message]
2022-08-20 23:18 ` [PATCH 3/3] disable HeapPageBody count test for Ruby 3.1 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220820213523.18504-4-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
--cc=sam.saffron@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).