From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH] tweak hpb stats destructor output
Date: Sat, 11 Aug 2018 03:53:36 +0000 [thread overview]
Message-ID: <20180811035336.1976-1-e@80x24.org> (raw)
Including the last rb_gc_count() call would be useful, and
avoid showing giant SIZE_MAX initializers for acc.min fields.
---
ext/mwrap/mwrap.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index 138384d..b60c21d 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -1351,21 +1351,26 @@ static void dump_hpb(FILE *fp, unsigned flags)
if (flags & DUMP_HPB_STATS) {
fprintf(fp,
"lifespan_max: %zu\n"
- "lifespan_min: %zu\n"
+ "lifespan_min:%s%zu\n"
"lifespan_mean: %0.3f\n"
"lifespan_stddev: %0.3f\n"
"deathspan_max: %zu\n"
- "deathspan_min: %zu\n"
+ "deathspan_min:%s%zu\n"
"deathspan_mean: %0.3f\n"
- "deathspan_stddev: %0.3f\n",
+ "deathspan_stddev: %0.3f\n"
+ "gc_count: %zu\n",
hpb_stats.alive.max,
+ hpb_stats.alive.min == SIZE_MAX ? " -" : " ",
hpb_stats.alive.min,
hpb_stats.alive.mean,
acc_stddev_dbl(&hpb_stats.alive),
hpb_stats.reborn.max,
+ hpb_stats.reborn.min == SIZE_MAX ? " -" : " ",
hpb_stats.reborn.min,
hpb_stats.reborn.mean,
- acc_stddev_dbl(&hpb_stats.reborn));
+ acc_stddev_dbl(&hpb_stats.reborn),
+ /* n.b.: unsafe to call rb_gc_count() in destructor */
+ generation);
}
if (flags & DUMP_HPB_EACH) {
struct alloc_hdr *h;
--
EW
reply other threads:[~2018-08-11 3:53 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180811035336.1976-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).