From: Eric Wong <e@80x24.org>
To: mwrap-public@80x24.org
Subject: [PATCH 16/19] do not track allocations for constructor and Init_
Date: Mon, 16 Jul 2018 21:19:30 +0000 [thread overview]
Message-ID: <20180716211933.5835-17-e@80x24.org> (raw)
In-Reply-To: <20180716211933.5835-1-e@80x24.org>
There's nothing a user can do about allocations which happen
in our constructor (aside from not using mwrap), so do not
track them.
---
ext/mwrap/mwrap.c | 11 ++++++++---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/ext/mwrap/mwrap.c b/ext/mwrap/mwrap.c
index 0a1f9b5..627bb63 100644
--- a/ext/mwrap/mwrap.c
+++ b/ext/mwrap/mwrap.c
@@ -61,6 +61,7 @@ static int resolving_malloc;
} \
} while (0)
+static __thread size_t locating;
static size_t generation;
static size_t page_size;
static struct cds_lfht *totals;
@@ -91,6 +92,7 @@ lfht_new(void)
__attribute__((constructor)) static void resolve_malloc(void)
{
int err;
+ ++locating;
#ifdef __FreeBSD__
/*
@@ -133,6 +135,7 @@ __attribute__((constructor)) static void resolve_malloc(void)
if (err)
fprintf(stderr, "pthread_atfork failed: %s\n", strerror(err));
page_size = sysconf(_SC_PAGESIZE);
+ --locating;
}
static void
@@ -162,8 +165,6 @@ my_mempcpy(void *dest, const void *src, size_t n)
#define RETURN_ADDRESS(nr) \
(uintptr_t)(__builtin_extract_return_addr(__builtin_return_address(nr)))
-static __thread size_t locating;
-
#define INT2STR_MAX (sizeof(int) == 4 ? 10 : 19)
static char *int2str(int num, char *dst, size_t * size)
{
@@ -1013,7 +1014,10 @@ static VALUE src_loc_name(VALUE self)
*/
void Init_mwrap(void)
{
- VALUE mod = rb_define_module("Mwrap");
+ VALUE mod;
+
+ ++locating;
+ mod = rb_define_module("Mwrap");
id_uminus = rb_intern("-@");
cSrcLoc = rb_define_class_under(mod, "SourceLocation", rb_cObject);
@@ -1029,6 +1033,7 @@ void Init_mwrap(void)
rb_define_method(cSrcLoc, "mean_lifespan", src_loc_mean_lifespan, 0);
rb_define_method(cSrcLoc, "max_lifespan", src_loc_max_lifespan, 0);
rb_define_method(cSrcLoc, "name", src_loc_name, 0);
+ --locating;
}
/* rb_cloexec_open isn't usable by non-Ruby processes */
--
EW
next prev parent reply other threads:[~2018-07-16 21:19 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-16 21:19 [PATCH 0/19] the heavy version of mwrap Eric Wong
2018-07-16 21:19 ` [PATCH 01/19] support per-allocation headers for per-alloc tracking Eric Wong
2018-07-16 21:19 ` [PATCH 02/19] mwrap: use malloc to do our own memalign Eric Wong
2018-07-16 21:19 ` [PATCH 03/19] hold RCU read lock to insert each allocation Eric Wong
2018-07-16 21:19 ` [PATCH 04/19] realloc: do not copy if allocation failed Eric Wong
2018-07-16 21:19 ` [PATCH 05/19] internal_memalign: do not assume real_malloc succeeds Eric Wong
2018-07-16 21:19 ` [PATCH 06/19] ensure ENOMEM is preserved in errno when appropriate Eric Wong
2018-07-16 21:19 ` [PATCH 07/19] memalign: check alignment on all public functions Eric Wong
2018-07-16 21:19 ` [PATCH 08/19] reduce stack usage from file names Eric Wong
2018-07-16 21:19 ` [PATCH 09/19] resolve real_malloc earlier for C++ programs Eric Wong
2018-07-16 21:19 ` [PATCH 10/19] allow analyzing live allocations via Mwrap[location] Eric Wong
2018-07-16 21:19 ` [PATCH 11/19] alias Mwrap.clear to Mwrap.reset Eric Wong
2018-07-16 21:19 ` [PATCH 12/19] implement accessors for SourceLocation Eric Wong
2018-07-16 21:19 ` [PATCH 13/19] mwrap_aref: quiet -Wshorten-64-to-32 warning Eric Wong
2018-07-16 21:19 ` [PATCH 14/19] fixes for FreeBSD 11.1 Eric Wong
2018-07-16 21:19 ` [PATCH 15/19] use memrchr to extract address under glibc Eric Wong
2018-07-16 21:19 ` Eric Wong [this message]
2018-07-16 21:19 ` [PATCH 17/19] disable memalign tracking by default Eric Wong
2018-07-16 21:19 ` [PATCH 18/19] support Mwrap.quiet to temporarily disable allocation tracking Eric Wong
2018-07-16 21:19 ` [PATCH 19/19] mwrap_rack: Rack app to track live allocations Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://80x24.org/mwrap/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716211933.5835-17-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-public@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).