From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] reduce branches for size class calculation
Date: Sat, 6 Apr 2024 21:49:44 +0000 [thread overview]
Message-ID: <20240406214944.159562-1-e@80x24.org> (raw)
We can use bit twiddling to find the next power-of-two without
branching for each iteration of the loop (since the new loop
is simple enough for a compiler to unroll).
---
mwrap_core.h | 16 ++++++----------
1 file changed, 6 insertions(+), 10 deletions(-)
diff --git a/mwrap_core.h b/mwrap_core.h
index 78c14e3..2a50e66 100644
--- a/mwrap_core.h
+++ b/mwrap_core.h
@@ -676,17 +676,13 @@ static inline size_t size_class_pad(size_t bytes)
* minimize fragmentation. This means we pay a 0-20% overhead on
* the initial allocations to improve the likelyhood of reuse.
*/
- size_t max = sizeof(void *) << 5;
- size_t nxt;
- do {
- if (bytes <= max) {
- size_t sc_bytes = size_align(bytes, max >> 3);
- return sc_bytes <= mm_thresh ? sc_bytes : bytes;
- }
- nxt = max << 1;
- } while (nxt > max && nxt < mm_thresh && (max = nxt));
+ size_t np2 = bytes - 1;
+ for (size_t i = 1; i < sizeof(size_t) * CHAR_BIT; i <<= 1)
+ np2 |= np2 >> i;
+ ++np2; // next power-of-two
- return bytes;
+ size_t sc_bytes = size_align(bytes, np2 >> 3);
+ return sc_bytes < mm_thresh ? sc_bytes : mm_thresh;
}
void *malloc(size_t size)
reply other threads:[~2024-04-06 21:49 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240406214944.159562-1-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).