mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 2/3] implement dynamic mmap threshold
Date: Wed,  3 Apr 2024 21:42:21 +0000	[thread overview]
Message-ID: <20240403214222.3258695-3-e@80x24.org> (raw)
In-Reply-To: <20240403214222.3258695-1-e@80x24.org>

mmap is an expensive operation, so follow glibc's lead and
adjust the mmap threshold dynamically.  Unlike glibc, there's no
way to disable this at the moment.  I don't think disabling is
worth the effort since avoiding mmap is the default in glibc and
few users change it.  Furthermore, avoiding mmap lets us test
the effectiveness of the prior size classes commit at reducing
fragmentation.
---
 dlmalloc_c.h | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/dlmalloc_c.h b/dlmalloc_c.h
index e842a53..348c194 100644
--- a/dlmalloc_c.h
+++ b/dlmalloc_c.h
@@ -5623,6 +5623,8 @@ void* mspace_malloc(mspace msp, size_t bytes) {
 }
 
 void mspace_free(mspace msp, void* mem) {
+  const size_t mm_thresh_max = 1 << (sizeof(void *) == 4 ? 19U : 25U);
+
   if (mem != 0) {
     mchunkptr p  = mem2chunk(mem);
 #if FOOTERS && 0 /* mwrap called get_mstate_for */
@@ -5643,7 +5645,15 @@ void mspace_free(mspace msp, void* mem) {
         if (!pinuse(p)) {
           size_t prevsize = p->prev_foot;
           if (is_mmapped(p)) {
+	    size_t asize = psize;
+
             psize += prevsize + MMAP_FOOT_PAD;
+
+            /* adjust dynamic mmap threshold, similar to glibc */
+            if (asize > mparams.mmap_threshold && asize <= mm_thresh_max) {
+              mparams.mmap_threshold = asize;
+              mparams.trim_threshold = asize * 2;
+            }
             if (CALL_MUNMAP((char*)p - prevsize, psize) == 0)
               fm->footprint -= psize;
             goto postaction;

  parent reply	other threads:[~2024-04-03 21:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-03 21:42 [PATCH 0/3] introduce size classes to reduce fragmentation Eric Wong
2024-04-03 21:42 ` [PATCH 1/3] dlmalloc: use jemalloc-inspired size classes Eric Wong
2024-04-03 21:42 ` Eric Wong [this message]
2024-04-03 21:42 ` [PATCH 3/3] malloc: revert file-backed mmap, sbrk for main arena Eric Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240403214222.3258695-3-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).