mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <mwrap-perl@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] fix uninitialized warnings
Date: Wed, 11 Jan 2023 04:29:29 +0000	[thread overview]
Message-ID: <20230111042929.25746-1-mwrap-perl@80x24.org> (raw)

The `dump_fd' warning is legit but wasn't caught on my other system.
The `lineno' warning pops up on my system with `-O0'
---
 mwrap_core.h | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/mwrap_core.h b/mwrap_core.h
index 86e4498..a2c6d4a 100644
--- a/mwrap_core.h
+++ b/mwrap_core.h
@@ -388,9 +388,8 @@ static const COP *mwp_curcop(void)
 static const char *mw_perl_src_file_cstr(unsigned *lineno)
 {
 	const COP *cop = mwp_curcop();
-	if (!cop) return NULL;
-	*lineno = CopLINE(cop);
-	return CopFILE(cop);
+	*lineno = cop ? CopLINE(cop) : 0;
+	return cop ? CopFILE(cop) : NULL;
 }
 #	define SRC_FILE_CSTR(lineno) mw_perl_src_file_cstr(lineno)
 #endif /* MWRAP_PERL */
@@ -922,9 +921,13 @@ __attribute__ ((destructor)) static void mwrap_dtor(void)
 			fprintf(stderr, "open %s failed: %m\n", dump_path);
 			goto out;
 		}
-	} else if ((s = strstr(opt, "dump_fd:")) &&
-			!sscanf(s, "dump_fd:%d", &dump_fd))
-		goto out;
+	} else {
+		s = strstr(opt, "dump_fd:");
+		if (!s)
+			goto out;
+		if (!sscanf(s, "dump_fd:%d", &dump_fd))
+			goto out;
+	}
 
 	/* allow dump_csv standalone for dump_fd */
 	if (!a.dump_csv && strstr(opt, "dump_csv"))

                 reply	other threads:[~2023-01-11  4:30 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230111042929.25746-1-mwrap-perl@80x24.org \
    --to=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).