mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] t/httpd.t: needs sqlite3 3.32.0+ for `.import --csv'
Date: Mon,  9 Jan 2023 00:01:09 +0000	[thread overview]
Message-ID: <20230109000109.2526156-1-e@80x24.org> (raw)

Just disable the test if CSV import doesn't work with the
currently-installed sqlite3.
---
 t/httpd.t | 19 ++++++++++++++-----
 1 file changed, 14 insertions(+), 5 deletions(-)

diff --git a/t/httpd.t b/t/httpd.t
index 7746837..8f56f64 100644
--- a/t/httpd.t
+++ b/t/httpd.t
@@ -135,19 +135,28 @@ SKIP: {
 
 SKIP: {
 	skip 'no reset w/o curl --unix-socket', 1 if !$curl_unix;
-
+	my ($sqlite_v) = (`sqlite3 --version` =~ /([\d+\.]+)/);
+	if ($?) {
+		diag 'sqlite3 missing or broken';
+		$sqlite_v = 0;
+	} else {
+		my @v = split(/\./, $sqlite_v);
+		$sqlite_v = ($v[0] << 16) | ($v[1] << 8) | $v[2];
+		diag 'sqlite_v='.sprintf('0x%x', $sqlite_v);
+	}
 	$rc = system(@curl, "http://0/$pid/each/100.csv");
 	is($rc, 0, '.csv retrieved') or skip 'CSV failed', 1;
 	my $db = "$mwrap_tmp/t.sqlite3";
-	$rc = system(qw(sqlite3), $db, ".import --csv $cout mwrap_each");
-	if ($rc == -1) {
-		diag 'sqlite3 missing';
-	} else {
+
+	if ($sqlite_v >= 0x32000) {
+		$rc = system(qw(sqlite3), $db,".import --csv $cout mwrap_each");
 		is($rc, 0, 'sqlite3 import');
 		my $n = `sqlite3 $db 'SELECT COUNT(*) FROM mwrap_each'`;
 		is($?, 0, 'sqlite3 count');
 		my $exp = split(/\n/, slurp($cout));
 		is($n + 1, $exp, 'imported all rows into sqlite');
+	} else {
+		diag "sqlite 3.32.0+ needed for `.import --csv'";
 	}
 
 	$rc = system(@curl, qw(-d x=y), "http://0/$pid/reset");

                 reply	other threads:[~2023-01-09  0:01 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230109000109.2526156-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).