mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] mymalloc.h: set mode with O_TMPFILE
Date: Sat,  7 Jan 2023 22:09:06 +0000	[thread overview]
Message-ID: <20230107220906.2464683-1-e@80x24.org> (raw)

Although we never vivify the O_TMPFILE to an non-FS path (via
linkat(2)), glibc may still complain about it since it doesn't
know we never call linkat(2)
---
 mymalloc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mymalloc.h b/mymalloc.h
index eda669f..6b5a22d 100644
--- a/mymalloc.h
+++ b/mymalloc.h
@@ -65,7 +65,7 @@ static void *my_mmap(size_t size)
 	if (!tmpdir)
 		tmpdir = "/tmp";
 
-	fd = open(tmpdir, O_TMPFILE|O_RDWR|S_IRUSR|S_IWUSR);
+	fd = open(tmpdir, O_TMPFILE|O_RDWR|S_IRUSR|S_IWUSR, 0600);
 	if (fd < 0) {
 		flags |= MAP_ANONYMOUS;
 	} else {

                 reply	other threads:[~2023-01-07 22:09 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230107220906.2464683-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).