mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <mwrap-perl@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] rproxy: support FreeBSD addr2line unresolved (??) output
Date: Tue, 27 Dec 2022 21:56:29 +0000	[thread overview]
Message-ID: <20221227215629.45883-1-mwrap-perl@80x24.org> (raw)

FreeBSD addr2line uses `?? at ??:0' for unresolved addresses, so
relax the regexp we use for handling unresolved output.
---
 lib/Devel/Mwrap/Rproxy.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/Devel/Mwrap/Rproxy.pm b/lib/Devel/Mwrap/Rproxy.pm
index b2bee8c..c96a947 100644
--- a/lib/Devel/Mwrap/Rproxy.pm
+++ b/lib/Devel/Mwrap/Rproxy.pm
@@ -66,7 +66,7 @@ sub a2l {
 	my $a2l = $addr2line{$exe} //= Devel::Mwrap::Rproxy::A2L->new($exe);
 	chomp(my $line = $a2l->lookup($addr));
 	$line = Plack::Util::encode_html($line);
-	$line =~ /\A\?\?:/ ? "$line $exe $addr" : $line;
+	$line =~ /\?\?/ ? "$line $exe $addr" : $line;
 }
 
 sub call { # PSGI entry point

                 reply	other threads:[~2022-12-27 21:55 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221227215629.45883-1-mwrap-perl@80x24.org \
    --to=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).