mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH] rproxy: have addr2line show inlines and function names
Date: Tue, 27 Dec 2022 21:39:55 +0000	[thread overview]
Message-ID: <20221227213955.1496327-1-e@80x24.org> (raw)

They're useful, IMHO.  The ADDR2LINE environment can override
it, of course.
---
 lib/Devel/Mwrap/Rproxy.pm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/lib/Devel/Mwrap/Rproxy.pm b/lib/Devel/Mwrap/Rproxy.pm
index 19fff59..b2bee8c 100644
--- a/lib/Devel/Mwrap/Rproxy.pm
+++ b/lib/Devel/Mwrap/Rproxy.pm
@@ -133,15 +133,17 @@ sub new {
 	my ($cls, $exe) = @_;
 	pipe(my ($rd, $_wr)) or die "pipe: $!";
 	pipe(my ($_rd, $wr)) or die "pipe: $!";
-	my $addr2line = $ENV{ADDR2LINE} // 'addr2line';
+	# -f/--functions needs -p/--pretty-print to go with it
+	my $addr2line = $ENV{ADDR2LINE} // 'addr2line -i -p -f';
+	my @addr2line = split(/\s+/, $addr2line);
 	my $pid = fork // die "fork: $!";
 	if ($pid == 0) {
 		close $rd;
 		close $wr;
 		open STDIN, '<&', $_rd or die "STDIN: $!";
 		open STDOUT, '>&', $_wr or die "STDOUT: $!";
-		exec $addr2line, '-e', $exe;
-		die "exec $addr2line -e $exe: $!";
+		exec @addr2line, '-e', $exe;
+		die "exec @addr2line -e $exe: $!";
 	}
 	$_rd = $_wr = undef;
 	$wr->autoflush(1);

                 reply	other threads:[~2022-12-27 21:39 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221227213955.1496327-1-e@80x24.org \
    --to=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).