From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 1/3] httpd: drop connection if 404 on POST bodies
Date: Wed, 21 Dec 2022 11:34:03 +0000 [thread overview]
Message-ID: <20221221113405.2129-2-e@80x24.org> (raw)
In-Reply-To: <20221221113405.2129-1-e@80x24.org>
Persistent connections and undrained input don't mix; so the
simplest thing is to drop the persistent connection when we
short-circuit out on /$PID/ prefix mismatches.
In retrospect, it's probably not worth supporting persistent
connections at all for a AF_UNIX-only server...
---
httpd.h | 1 +
t/httpd.t | 4 ++++
2 files changed, 5 insertions(+)
diff --git a/httpd.h b/httpd.h
index eddea97..a59c9dd 100644
--- a/httpd.h
+++ b/httpd.h
@@ -310,6 +310,7 @@ static enum mw_qev h1_404(struct mw_h1 *h1)
static const char r404[] = "HTTP/1.1 404 Not Found\r\n"
"Content-Type: text/html\r\n"
"Content-Length: 10\r\n\r\n" "Not Found\n";
+ if (h1->has_input) h1->persist = 0;
return h1_res_oneshot(h1, r404, sizeof(r404) - 1);
}
diff --git a/t/httpd.t b/t/httpd.t
index 3fe9c1f..53cf420 100644
--- a/t/httpd.t
+++ b/t/httpd.t
@@ -161,6 +161,10 @@ SKIP: {
'-HX-Mwrap-BT-Depth:10', '-XPOST', "http://0/$pid/ctl");
is($rc, 0, 'curl /ctl (X-Mwrap-BT-Depth)');
like(slurp($cout), qr/\bMWRAP=bt:10\b/, 'changed bt depth');
+
+ $rc = system(qw(curl -vsSf --unix-socket), $sock, '-o', $cout,
+ '-HX-Mwrap-BT-Depth:10', '-d', 'blah', "http://0/ctl");
+ is($rc >> 8, 22, '404 w/o PID prefix');
};
next prev parent reply other threads:[~2022-12-21 11:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-21 11:34 [PATCH 0/3] httpd: debloating and refining Eric Wong
2022-12-21 11:34 ` Eric Wong [this message]
2022-12-21 11:34 ` [PATCH 2/3] httpd: drop persistent connection support Eric Wong
2022-12-21 11:34 ` [PATCH 3/3] httpd: do not waste TSD space Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221221113405.2129-2-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).