From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 3/7] core: drop FreeBSD-specific mutex initialization
Date: Mon, 19 Dec 2022 11:19:18 +0000 [thread overview]
Message-ID: <20221219111922.1079128-4-e@80x24.org> (raw)
In-Reply-To: <20221219111922.1079128-1-e@80x24.org>
From: Eric Wong <mwrap-perl@80x24.org>
It's no longer needed with our embedded malloc and our
non-glibc ensure_initialization() mutex avoidance hack.
---
mwrap_core.h | 15 +--------------
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/mwrap_core.h b/mwrap_core.h
index 7f52f39..b382018 100644
--- a/mwrap_core.h
+++ b/mwrap_core.h
@@ -87,18 +87,11 @@ union padded_mutex {
char pad[64]; /* cache alignment for common CPUs */
};
-/* a round-robin pool of mutexes */
+/* a pool of mutexes for all "struct src_loc" */
#define MUTEX_NR (1 << 6)
#define MUTEX_MASK (MUTEX_NR - 1)
-#ifdef __FreeBSD__
-# define STATIC_MTX_INIT_OK (0)
-#else /* only tested on Linux + glibc */
-# define STATIC_MTX_INIT_OK (1)
-#endif
static union padded_mutex mutexes[MUTEX_NR] = {
-#if STATIC_MTX_INIT_OK
[0 ... (MUTEX_NR-1)].mtx = PTHREAD_MUTEX_INITIALIZER
-#endif
};
#ifdef static_assert
@@ -1010,12 +1003,6 @@ __attribute__((constructor)) static void mwrap_ctor(void)
ensure_initialization();
CHECK(int, 0, pthread_key_create(&tlskey, mstate_tsd_dtor));
- /*
- * PTHREAD_MUTEX_INITIALIZER on FreeBSD means lazy initialization,
- * which happens at pthread_mutex_lock, and that calls calloc
- */
- if (!STATIC_MTX_INIT_OK)
- reset_mutexes();
/* initialize mutexes used by urcu-bp */
CMM_STORE_SHARED(files, lfht_new(256));
if (!CMM_LOAD_SHARED(files))
next prev parent reply other threads:[~2022-12-19 11:19 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-19 11:19 [PATCH 0/7] shrinkage Eric Wong
2022-12-19 11:19 ` [PATCH 1/7] core: shrink src_loc 8 bytes on x86-64 Eric Wong
2022-12-19 11:19 ` [PATCH 2/7] core: shrink src_loc by another " Eric Wong
2022-12-19 11:19 ` Eric Wong [this message]
2022-12-19 11:19 ` [PATCH 4/7] calloc: consolidate ENOMEM handling Eric Wong
2022-12-19 11:19 ` [PATCH 5/7] *alloc: limit scope of RCU lock Eric Wong
2022-12-19 11:19 ` [PATCH 6/7] core: simplify callers of alloc_insert_rcu Eric Wong
2022-12-19 11:19 ` [PATCH 7/7] README: add some caveats (signalfd usage w/ current URCU) Eric Wong
2022-12-19 22:57 ` [WIP] attempt to workaround older URCU for signalfd Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221219111922.1079128-4-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).