From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-4.1 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 6007C1FAF5 for ; Thu, 15 Dec 2022 20:52:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=80x24.org; s=selector1; t=1671137577; bh=1+Bz2RXUrBf2rxZNkgbw3tyGT5lF8hY6P6fx4hjoVhM=; h=From:To:Subject:Date:In-Reply-To:References:From; b=RZGnAJZ/R6exXBT1EV5ggGl/3j75dWWJqyti4FJtvAd9jT7rxtuDeDE9Sj+WzEFiL 8AnUxPV7EgMmZdp2jUCOLnqLDfqq98ltO8+pxI7hNBWleXHvMeHGYhnv74USAU3vz7 /ZEFccgNsULSSA5O2IiAYcwGaGpMCHxATt5NsOJE= From: Eric Wong To: mwrap-perl@80x24.org Subject: [PATCH 07/19] use uatomic_inc where appropriate Date: Thu, 15 Dec 2022 20:52:43 +0000 Message-Id: <20221215205255.27840-8-e@80x24.org> In-Reply-To: <20221215205255.27840-1-e@80x24.org> References: <20221215205255.27840-1-e@80x24.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: It's slightly more readable IMHO, and perhaps it generates better code on x86 (since URCU has x86-specific paths for it). --- mwrap_core.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mwrap_core.h b/mwrap_core.h index 4dc28d4..d798b79 100644 --- a/mwrap_core.h +++ b/mwrap_core.h @@ -280,7 +280,7 @@ again: l = src_loc_get(t, k); if (l) { uatomic_add(&l->total, k->total); - uatomic_add(&l->allocations, 1); + uatomic_inc(&l->allocations); } else { size_t n = bt_bytelen(k) + sizeof(*k); struct cds_lfht_node *cur; @@ -462,7 +462,7 @@ void free(void *p) uatomic_add(&total_bytes_dec, h->size); uatomic_add(&l->freed_bytes, h->size); uatomic_set(&h->size, 0); - uatomic_add(&l->frees, 1); + uatomic_inc(&l->frees); uatomic_add(&l->age_total, age); CHECK(int, 0, pthread_mutex_lock(l->mtx));