From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 4/4] httpd: fix leaks when using persistent connections
Date: Sat, 10 Dec 2022 10:01:44 +0000 [thread overview]
Message-ID: <20221210100144.19796-5-e@80x24.org> (raw)
In-Reply-To: <20221210100144.19796-1-e@80x24.org>
Persistent connections is probably not going to be a real use
case, but I may end up supporting them anyways.
---
mwrap_httpd.h | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/mwrap_httpd.h b/mwrap_httpd.h
index fe9f292..ef215c8 100644
--- a/mwrap_httpd.h
+++ b/mwrap_httpd.h
@@ -173,6 +173,9 @@ static enum mw_qev h1_send_flush(struct mw_h1 *h1)
struct mw_wbuf *wbuf = h1->wbuf;
struct msghdr mh = { 0 };
+ free(h1->h1r);
+ h1->h1r = NULL;
+
mh.msg_iov = wbuf->iov + wbuf->iov_written;
mh.msg_iovlen = wbuf->iov_nr;
do {
@@ -674,6 +677,7 @@ static enum mw_qev h1_parse_harder(struct mw_h1 *h1, struct mw_h1req *h1r)
char *end;
struct phr_header *hdr = h1r->hdr;
+ h1->prev_len = 0;
h1->has_input = 0;
h1->persist = h1r->minor_ver >= 1 ? 1 : 0;
h1->in_len = 0;
prev parent reply other threads:[~2022-12-10 10:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 10:01 [PATCH 0/4] httpd fixes Eric Wong
2022-12-10 10:01 ` [PATCH 1/4] t/httpd-unit: extra test for fencepost errors Eric Wong
2022-12-10 20:45 ` Eric Wong
2022-12-10 10:01 ` [PATCH 2/4] t/mwrap-httpd: better errors for local socket failures Eric Wong
2022-12-10 10:01 ` [PATCH 3/4] rproxy: fix for `plackup --path=/$PREFIX/' mounts Eric Wong
2022-12-10 10:01 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210100144.19796-5-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).