From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: Re: [PATCH 3/3] C-only HTTP Unix socket server + PSGI TCP reverse proxy
Date: Sat, 10 Dec 2022 02:59:15 +0000 [thread overview]
Message-ID: <20221210025915.M446239@dcvr> (raw)
In-Reply-To: <20221210015518.272576-4-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> index 730699a..bed43d6 100644
> --- a/mwrap_core.h
> +++ b/mwrap_core.h
> +/* extract from backtrace_symbols(3) output */
> static int extract_addr(const char *str, size_t len, void **p)
> {
> - const char *c;
> -#if defined(__GLIBC__)
> - return ((c = memrchr(str, '[', len)) && sscanf(c, "[%p]", p));
> -#else /* TODO: test FreeBSD */
> - return ((c = strstr(str, "0x")) && sscanf(c, "%p", p));
> + unsigned long x;
> + char *e;
> +#if defined(__GLIBC__) /* str = "/path/to/foo.so(+0x123) [0xdeadbeefcafe]" */
> + const char *end = str + len;
> + const char *c = memrchr(str, '[', len);
> + if (c && (c + 2) < end && c[1] == '0' && c[2] == 'x') {
> + errno = 0;
> + x = strtoul(c + 3, &e, 16);
> + if (!errno && *e == ']') {
> + *p = (void *)x;
> + return 1;
> + }
> + }
> +#elif defined(__FreeBSD__) /* str = "0xdeadbeefcafe <%n%D> at %f" */
> + const char *c = memchr(str, ' ', len);
> + errno = 0;
> + if (len > 4 && c && str[0] == '0' && str[1] == 'x') {
> + errno = 0;
> + x = strtoul(str + 3, &e, 16);
Erm, that should be `str + 2' on FreeBSD to skip "0x":
diff --git a/mwrap_core.h b/mwrap_core.h
index bed43d6..b2d0511 100644
--- a/mwrap_core.h
+++ b/mwrap_core.h
@@ -739,7 +739,7 @@ static int extract_addr(const char *str, size_t len, void **p)
errno = 0;
if (len > 4 && c && str[0] == '0' && str[1] == 'x') {
errno = 0;
- x = strtoul(str + 3, &e, 16);
+ x = strtoul(str + 2, &e, 16);
if (!errno && *e == ' ') {
*p = (void *)x;
return 1;
prev parent reply other threads:[~2022-12-10 2:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-10 1:55 [PATCH 0/3] C-only HTTP Unix socket server + PSGI TCP reverse proxy Eric Wong
2022-12-10 1:55 ` [PATCH 1/3] move mwrap_reset to core Eric Wong
2022-12-10 1:55 ` [PATCH 2/3] tests: hoist out test_common.perl Eric Wong
2022-12-10 1:55 ` [PATCH 3/3] C-only HTTP Unix socket server + PSGI TCP reverse proxy Eric Wong
2022-12-10 2:59 ` Eric Wong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221210025915.M446239@dcvr \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).