From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: Re: [PATCH v2 1/2] use file-backed mmap on Linux
Date: Fri, 2 Dec 2022 10:14:24 +0000 [thread overview]
Message-ID: <20221202101424.M322283@dcvr> (raw)
In-Reply-To: <20221130210837.17163-2-e@80x24.org>
Eric Wong <e@80x24.org> wrote:
> + fd = open(tmpdir, O_TMPFILE|O_RDWR|S_IRUSR);
Erm, missing S_IWUSR bit :x pushed with the following:
diff --git a/mymalloc.h b/mymalloc.h
index 94f2c7a..7b18486 100644
--- a/mymalloc.h
+++ b/mymalloc.h
@@ -49,7 +49,7 @@ static void *my_mmap(size_t size)
if (!tmpdir)
tmpdir = "/tmp";
- fd = open(tmpdir, O_TMPFILE|O_RDWR|S_IRUSR);
+ fd = open(tmpdir, O_TMPFILE|O_RDWR|S_IRUSR|S_IWUSR);
if (fd < 0) {
flags |= MAP_ANONYMOUS;
} else {
next prev parent reply other threads:[~2022-12-02 10:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-30 6:49 [PATCH 0/2] support file-backed mmap on Linux Eric Wong
2022-11-30 6:49 ` [PATCH 1/2] use " Eric Wong
2022-11-30 20:43 ` Eric Wong
2022-11-30 6:49 ` [PATCH 2/2] increase DEFAULT_GRANULARITY to 64M Eric Wong
2022-11-30 21:08 ` [PATCH v2 0/2] support file-backed mmap on Linux Eric Wong
2022-11-30 21:08 ` [PATCH v2 1/2] use " Eric Wong
2022-12-02 10:14 ` Eric Wong [this message]
2022-11-30 21:08 ` [PATCH v2 2/2] increase DEFAULT_GRANULARITY to 64M Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221202101424.M322283@dcvr \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).