From: Eric Wong <e@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 2/6] Devel::Mwrap::reset is a no-op if `totals' not initialized
Date: Tue, 15 Nov 2022 19:33:37 +0000 [thread overview]
Message-ID: <20221115193341.3948245-3-e@80x24.org> (raw)
In-Reply-To: <20221115193341.3948245-1-e@80x24.org>
Don't segfault in case we fail to create rculfhash.
---
Mwrap.xs | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index 518edb1..e87fe30 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -909,14 +909,15 @@ CODE:
rcu_read_lock();
t = CMM_LOAD_SHARED(totals);
- cds_lfht_for_each_entry(t, &iter, l, hnode) {
- uatomic_set(&l->total, 0);
- uatomic_set(&l->allocations, 0);
- uatomic_set(&l->frees, 0);
- uatomic_set(&l->freed_bytes, 0);
- uatomic_set(&l->age_total, 0);
- uatomic_set(&l->max_lifespan, 0);
- }
+ if (t)
+ cds_lfht_for_each_entry(t, &iter, l, hnode) {
+ uatomic_set(&l->total, 0);
+ uatomic_set(&l->allocations, 0);
+ uatomic_set(&l->frees, 0);
+ uatomic_set(&l->freed_bytes, 0);
+ uatomic_set(&l->age_total, 0);
+ uatomic_set(&l->max_lifespan, 0);
+ }
rcu_read_unlock();
Devel::Mwrap::SrcLoc
next prev parent reply other threads:[~2022-11-15 19:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-15 19:33 [PATCH 0/6] bugfixes, workarounds, and built-in malloc Eric Wong
2022-11-15 19:33 ` [PATCH 1/6] test cfree and aligned_alloc aliases Eric Wong
2022-11-15 19:33 ` Eric Wong [this message]
2022-11-15 19:33 ` [PATCH 3/6] block signals when spawning URCU-related threads Eric Wong
2022-11-15 19:33 ` [PATCH 4/6] document of kbuf allocation size Eric Wong
2022-11-15 19:33 ` [PATCH 5/6] mwrap-perl: use grep and fix regexp Eric Wong
2022-11-15 19:33 ` [PATCH 6/6] split out mwrap_core.h and use provide our own malloc Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221115193341.3948245-3-e@80x24.org \
--to=e@80x24.org \
--cc=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).