From: Eric Wong <mwrap-perl@80x24.org>
To: mwrap-perl@80x24.org
Subject: [PATCH 3/4] use macro to quiet uninitialized and unused variable warnings
Date: Sat, 3 Sep 2022 11:18:27 +0000 [thread overview]
Message-ID: <20220903111828.2316808-4-mwrap-perl@80x24.org> (raw)
In-Reply-To: <20220903111828.2316808-1-mwrap-perl@80x24.org>
This allows us to avoid some #ifdefs inside function bodies.
This cleanup comes from the Ruby version.
---
Mwrap.xs | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/Mwrap.xs b/Mwrap.xs
index 3392fee..9e9f571 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -153,14 +153,18 @@ __attribute__((constructor)) static void resolve_malloc(void)
--locating;
}
+#ifdef NDEBUG
+#define QUIET_CC_WARNING(var) (void)var;
+#else
+#define QUIET_CC_WARNING(var)
+#endif
+
static void
mutex_lock(pthread_mutex_t *m)
{
int err = pthread_mutex_lock(m);
assert(err == 0);
-#ifdef NDEBUG
- (void)err; /* quiet gcc warning */
-#endif
+ QUIET_CC_WARNING(err)
}
static void
@@ -168,9 +172,7 @@ mutex_unlock(pthread_mutex_t *m)
{
int err = pthread_mutex_unlock(m);
assert(err == 0);
-#ifdef NDEBUG
- (void)err; /* quiet gcc warning */
-#endif
+ QUIET_CC_WARNING(err)
}
#ifndef HAVE_MEMPCPY
next prev parent reply other threads:[~2022-09-03 11:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-03 11:18 [PATCH 0/4] various cleanups and fixes from the Ruby side Eric Wong
2022-09-03 11:18 ` [PATCH 1/4] favor _Thread_local under C11 Eric Wong
2022-09-03 11:18 ` [PATCH 2/4] cleanup some FreeBSD-related workarounds Eric Wong
2022-09-04 7:01 ` Eric Wong
2022-09-03 11:18 ` Eric Wong [this message]
2022-09-03 11:18 ` [PATCH 4/4] workaround breakage from urcu v0.11.4 Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220903111828.2316808-4-mwrap-perl@80x24.org \
--to=mwrap-perl@80x24.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mwrap-perl.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).