mwrap (Perl version) user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Eric Wong <user@example.com>
To: mwrap-perl@80x24.org
Cc: Eric Wong <e@80x24.org>
Subject: [PATCH 4/4] avoid mixing declarations and code
Date: Sat,  2 Nov 2019 10:40:20 +0000	[thread overview]
Message-ID: <20191102104020.30317-5-user@example.com> (raw)
In-Reply-To: <20191102104020.30317-1-user@example.com>

From: Eric Wong <e@80x24.org>

This quiets warnings when using -Wdeclaration-after-statement
which is still common in some circles.
---
 Mwrap.xs | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Mwrap.xs b/Mwrap.xs
index 4d346ab..09d5581 100644
--- a/Mwrap.xs
+++ b/Mwrap.xs
@@ -851,8 +851,8 @@ PREINIT:
 	struct cds_lfht_node *cur;
 	struct cds_lfht *t;
 	struct src_loc *l = NULL;
-	++locating;
 CODE:
+	++locating;
 	if (!SvPOK(loc))
 		XSRETURN_UNDEF;
 	str = SvPV(loc, len);
@@ -897,8 +897,8 @@ size_t
 src_loc_frees(self)
 	Devel::Mwrap::SrcLoc self
 PREINIT:
-	++locating;
 CODE:
+	++locating;
 	RETVAL = uatomic_read(&self->frees);
 OUTPUT:
 	RETVAL
@@ -909,8 +909,8 @@ size_t
 src_loc_allocations(self)
 	Devel::Mwrap::SrcLoc self
 PREINIT:
-	++locating;
 CODE:
+	++locating;
 	RETVAL = uatomic_read(&self->allocations);
 OUTPUT:
 	RETVAL
@@ -921,8 +921,8 @@ size_t
 src_loc_total(self)
 	Devel::Mwrap::SrcLoc self
 PREINIT:
-	++locating;
 CODE:
+	++locating;
 	RETVAL = uatomic_read(&self->total);
 OUTPUT:
 	RETVAL
@@ -933,8 +933,8 @@ SV *
 src_loc_name(self)
 	Devel::Mwrap::SrcLoc self
 PREINIT:
-	++locating;
 CODE:
+	++locating;
 	RETVAL = location_string(self);
 OUTPUT:
 	RETVAL

      parent reply	other threads:[~2019-11-02 10:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-02 10:40 [PATCH 0/4] build system fixes Eric Wong
2019-11-02 10:40 ` [PATCH 1/4] Makefile.PL: remove CCFLAGS overrides Eric Wong
2019-11-02 10:40 ` [PATCH 2/4] workaround -DNDEBUG warnings Eric Wong
2019-11-02 10:40 ` [PATCH 3/4] quiet uninitialized variable warnings Eric Wong
2019-11-02 10:40 ` Eric Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191102104020.30317-5-user@example.com \
    --to=user@example.com \
    --cc=e@80x24.org \
    --cc=mwrap-perl@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mwrap-perl.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).