From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: X-Spam-Status: No, score=-3.5 required=3.0 tests=ALL_TRUSTED,AWL,BAYES_00 shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from localhost (dcvr.yhbt.net [127.0.0.1]) by dcvr.yhbt.net (Postfix) with ESMTP id 8364D1F4C4; Sat, 2 Nov 2019 10:40:21 +0000 (UTC) From: Eric Wong To: mwrap-perl@80x24.org Cc: Eric Wong Subject: [PATCH 3/4] quiet uninitialized variable warnings Date: Sat, 2 Nov 2019 10:40:19 +0000 Message-Id: <20191102104020.30317-4-user@example.com> In-Reply-To: <20191102104020.30317-1-user@example.com> References: <20191102104020.30317-1-user@example.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit List-Id: From: Eric Wong -Wmaybe-uninitialized (tested gcc 8.3.0) needlessly warns about this, but it's a good simplification nevertheless. --- Mwrap.xs | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Mwrap.xs b/Mwrap.xs index 8ce7b46..4d346ab 100644 --- a/Mwrap.xs +++ b/Mwrap.xs @@ -469,16 +469,14 @@ internal_memalign(void **pp, size_t alignment, size_t size, uintptr_t caller) static void * memalign_result(int err, void *p) { - if (caa_unlikely(err)) { + if (caa_unlikely(err)) errno = err; - return 0; - } return p; } void *memalign(size_t alignment, size_t size) { - void *p; + void *p = NULL; int err = internal_memalign(&p, alignment, size, RETURN_ADDRESS(0)); return memalign_result(err, p); } @@ -493,7 +491,7 @@ void cfree(void *) __attribute__((alias("free"))); void *valloc(size_t size) { - void *p; + void *p = NULL; int err = internal_memalign(&p, page_size, size, RETURN_ADDRESS(0)); return memalign_result(err, p); } @@ -511,7 +509,7 @@ void *valloc(size_t size) void *pvalloc(size_t size) { size_t alignment = page_size; - void *p; + void *p = NULL; int err; if (add_overflow_p(size, alignment)) {