Re: library usage

[Dimid Duchovny <dimidd@gmail.com>]

2017-12-27 20:01 GMT+02:00 Eric Wong <e@80x24.org>:
> Dimid Duchovny <dimidd@gmail.com> wrote:
>> Hello,
>>
>> I've tried to use the library with a simple example, 2 messages where
>> one is a reply to the other:
>> require 'msgthr'
>> m1 = {id: 1, subject: 's1'}
>> m2 = {id: 2, subject: 're: s1'}
>> msgthr = Msgthr.new
>> msgthr.add 1, nil, m1
>> msgthr.add 2, [1], m2
>> msgthr.thread!
>
> msgthr.order! { |_| } # noop sort, necessary to flatten internal structures
>
>> msgthr.walk_thread do |level, container, index|
>>   msg = container.msg
>>   subject = msg ? msg[:subject] : "[missing: <#{container.mid}>]"
>>   indent = '  ' * level
>>   printf("#{indent} % 3d. %s\n", index, subject)
>> end
>>
>> Which fails with:
>> msgthr.rb:9:in `block in <main>': undefined method `msg' for
>> #<Array:0x00007ff404841958> (NoMethodError)
>>
>> Am I missing something?
>
> Oops, i guess the documentation is currently wrong in that
> order! is not optional.  But a noop block passed to order!
> should work for now.
>
> I will make it optional for the next release, and probably
> allow the proc as an arg to thread! to simplify the API.
>
> Thanks for the report and sorry for the breakage!

Thank you for the quick reply. IMHO, the best option would be indeed
to add an optional proc to thread! . If nil, it would be equivalent to
the noop order!.