From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS3215 2.6.0.0/16 X-Spam-Status: No, score=-3.5 required=3.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS shortcircuit=no autolearn=ham autolearn_force=no version=3.4.0 Received: from mail-vk0-x22b.google.com (mail-vk0-x22b.google.com [IPv6:2607:f8b0:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dcvr.yhbt.net (Postfix) with ESMTPS id 0DD6E1F404; Tue, 23 Jan 2018 21:13:35 +0000 (UTC) Received: by mail-vk0-x22b.google.com with SMTP id j204so1203453vke.12; Tue, 23 Jan 2018 13:13:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t2RP4qqE9bSS+FM7lBwqFi9dxLihfgQrIg/u+BhTolU=; b=S/yCXpJKOOTPd09Dt5KWbSpYVI34Ncp+ien9DgpoRMYHcIz9KIB5p1W2qYD6OZJU39 RrQHK3VqFruFHcR+W3Fl7pi+/qCsYFy6SQo7ubGbAIbzW25BRgS/1Pnqa1NSeyn5BJwE ea1KkcZvGjBRV9S1Prpad9EjxPCunTqMlT5T3CB7qwTqh4fTD+/zeF866YbFvBOp8sRj XMVZ7X8daKfMQ8+RvgMrVnnSWDSZqaUfTVXihqa12rFNIrFbM2mfOSMVh+zTCKgAly3x QYKPPiKuQKeMeNPzlmZlx7baiamwiRGf7SOwrKNd/y6tLHY/6KO0/npD+c4Bd/92Z0z0 dqDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t2RP4qqE9bSS+FM7lBwqFi9dxLihfgQrIg/u+BhTolU=; b=cKZC/FQIvmiQXrXuhDl+GwPWNLW3wmzjbthHtJbSHsdngDujCOHPlvA5/ICqSPDH5u JH1G6vildrM/PaImmsKmTmUT6J4AuBlpCTe746tbDtWh/APZEXIz8XSqGV+jlWWxQv3R HKAtfxk7xLOn1NggP1X3JSlzFYdHjW8/E+agR2QhE6ZnrGf+LUmksMJgG4gepuMs6FSA jdhAetZhcOonBm1cmYJOs4shP4Vaoq1KsFImdyAYDTNDGYCSZSbeGqCvb0Cd/MvpBy2u mUgxIgDsWoH3+cBPGrAiXVx1XgT6qIo//QLxevfkexKW1kAEStfPJa2bTUEWHcwC6TzR wtHg== X-Gm-Message-State: AKwxytcUj8Mu4zEokxXUtX5nyXCajupfEh3mYriM0w43HnxGxh5tUdA6 kN54TCCKaxR8WHcc7mZJSVYT/0oBIJuw3g/Eg+Uh2g== X-Google-Smtp-Source: AH8x226seTFL2FL8yfPK/2UBOcNqt+NkKIeZ7du8dOr0+q2/Y/Vi1YNBd3JxmgE3uvOFmsAFGCtXDOcmTpXoyYWj3+8= X-Received: by 10.31.188.72 with SMTP id m69mr2629145vkf.86.1516742013958; Tue, 23 Jan 2018 13:13:33 -0800 (PST) MIME-Version: 1.0 Received: by 10.176.21.2 with HTTP; Tue, 23 Jan 2018 13:12:53 -0800 (PST) In-Reply-To: References: <20180121234911.GA29238@whir> From: Dimid Duchovny Date: Tue, 23 Jan 2018 23:12:53 +0200 Message-ID: Subject: Re: Feature Request: thread grouping To: Eric Wong Cc: msgthr-public Content-Type: text/plain; charset="UTF-8" List-Id: Sorry, the link should be: https://github.com/dimidd/msgthr/commit/1c701717d10879d492d8b55fb8ca2f1c53d7e13f.diff 2018-01-23 23:04 GMT+02:00 Dimid Duchovny : > 2018-01-22 1:49 GMT+02:00 Eric Wong : >> Dimid Duchovny wrote: >>> However, I realized that the last step (walking) is redundant, >>> since that could be done by the library itself in the threading or >>> ordering stages. >> >> I think you want is best done in the storage/indexing stage; >> whereas msgthr is intended for display/rendering results that >> were retrieved from some sort of search engine. >> > > You're right. In my case the flow was: read emails from storage -> > group to threads -> add thread field to storage. > However, I guess it's an edge-case. > On second thought, maybe it'd be better to have a more general solution. > E.g. let the client run an arbitrary callback after adding a child. > > Here's a quick POC: > https://github.com/dimidd/msgthr/commit/1c701717d10879d492d8b55fb8ca2f1c53d7e13f > > P.S. I hope you don't mind I uploaded my fork to github.