msgthr user+dev discussion/patches/pulls/bugs/help
 help / color / mirror / code / Atom feed
From: Dimid Duchovny <dimidd@gmail.com>
To: Eric Wong <e@80x24.org>
Cc: msgthr-public <msgthr-public@80x24.org>
Subject: Re: Feature Request: thread grouping
Date: Tue, 23 Jan 2018 23:12:53 +0200	[thread overview]
Message-ID: <CANKvuDdpnbZdp-L1OQBhF5pHSxukRuO_DfdnvVm1cqxXrVFkug@mail.gmail.com> (raw)
In-Reply-To: <CANKvuDcS4_VJMiSxnHdUA+7sdVdeCxkp_L8+re_Z3D=W9-ep_A@mail.gmail.com>

Sorry, the link should be:
https://github.com/dimidd/msgthr/commit/1c701717d10879d492d8b55fb8ca2f1c53d7e13f.diff

2018-01-23 23:04 GMT+02:00 Dimid Duchovny <dimidd@gmail.com>:
> 2018-01-22 1:49 GMT+02:00 Eric Wong <e@80x24.org>:
>> Dimid Duchovny <dimidd@gmail.com> wrote:
>>> However, I realized that the last step (walking) is redundant,
>>> since that could be done by the library itself in the threading or
>>> ordering stages.
>>
>> I think you want is best done in the storage/indexing stage;
>> whereas msgthr is intended for display/rendering results that
>> were retrieved from some sort of search engine.
>>
>
> You're right. In my case the flow was: read emails from storage ->
> group to threads -> add thread field to storage.
> However, I guess it's an edge-case.
> On second thought, maybe it'd be better to have a more general solution.
> E.g. let the client run an arbitrary callback after adding a child.
>
> Here's a quick POC:
> https://github.com/dimidd/msgthr/commit/1c701717d10879d492d8b55fb8ca2f1c53d7e13f
>
> P.S. I hope you don't mind I uploaded my fork to github.

  reply	other threads:[~2018-01-23 21:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-21  9:40 Feature Request: thread grouping Dimid Duchovny
2018-01-21 23:49 ` Eric Wong
2018-01-23 21:04   ` Dimid Duchovny
2018-01-23 21:12     ` Dimid Duchovny [this message]
2018-01-23 22:03       ` Eric Wong
2018-01-24 10:28         ` Dimid Duchovny
2018-01-24 19:18           ` Eric Wong
2018-01-24 21:14             ` Dimid Duchovny
2018-01-24 22:49               ` Eric Wong
2018-01-25  8:16                 ` Dimid Duchovny
2018-01-25  8:38                   ` Eric Wong
2018-02-08 13:06                     ` Dimid Duchovny

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://80x24.org/msgthr/README

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANKvuDdpnbZdp-L1OQBhF5pHSxukRuO_DfdnvVm1cqxXrVFkug@mail.gmail.com \
    --to=dimidd@gmail.com \
    --cc=e@80x24.org \
    --cc=msgthr-public@80x24.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/msgthr.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).