From: Jose Quaresma <quaresma.jose@gmail.com>
To: Scott Murray <scott.murray@konsulko.com>
Cc: Sundeep KOKKONDA <Sundeep.Kokkonda@windriver.com>,
Yash Shinde <Yash.Shinde@windriver.com>,
Richard Purdie <richard.purdie@linuxfoundation.org>,
yocto@lists.yoctoproject.org
Subject: Re: [meta-lts-mixins][kirkstone/rust][PATCH 10/11] rust: reproducibility issue fix with v1.75
Date: Mon, 18 Mar 2024 10:03:02 +0000 [thread overview]
Message-ID: <CANPvuRnKNiAqF4DWw34+CbrW9YyfChJDLQrD8vR3_rZisonnSg@mail.gmail.com> (raw)
In-Reply-To: <e0fc85fd-bd14-ff20-5391-303ff5939041@konsulko.com>
[-- Attachment #1: Type: text/plain, Size: 5638 bytes --]
Thanks for the update.
Jose
Scott Murray <scott.murray@konsulko.com> escreveu (segunda, 18/03/2024 à(s)
00:10):
> On Tue, 12 Mar 2024, Scott Murray wrote:
>
> > On Tue, 12 Mar 2024, Jose Quaresma wrote:
> >
> > > Hi Sundeep,
> > >
> > > Sundeep KOKKONDA <Sundeep.Kokkonda@windriver.com> escreveu (terça,
> > > 12/03/2024 à(s) 03:45):
> > >
> > > > Hello,
> > > >
> > > > FYI. There is a V2 available for this patch with upstream fix
> backport.
> > > > You can consider that.
> > > >
> > > > https://lists.openembedded.org/g/openembedded-core/message/196856
> > >
> > >
> > > Sure, when this one is integrated on the master branch I can create a
> > > backport for it too.
> > > Thanks for the notification.
> >
> > I got back from a couple of weeks out of the office (conference followed
> > by vacation) yesterday, I aim to test the patch series locally and merge
> > it to kirkstone/rust in the next couple of days. We now seem to need
> > newer than Rust 1.70 for a recipe in AGL, so I'll likely be switching AGL
> > to using kirkstone/rust as well.
>
> I have merged the current patch series to kirkstone/rust with a minor
> tweak to update the layer.conf RUSTVERSION over-ride to match 1.75, and
> adding pointers to the original oe-core commits in the commit messages.
>
> Thanks,
>
> Scott
>
>
> > > > On 11-Mar-24 21:54, Jose Quaresma wrote:
> > > > > CAUTION: This email comes from a non Wind River email account!
> > > > > Do not click links or open attachments unless you recognize the
> sender
> > > > and know the content is safe.
> > > > >
> > > > > From: Yash Shinde <Yash.Shinde@windriver.com>
> > > > >
> > > > > With 1.75 rust release, the '.rustc' section of shared object libs
> are
> > > > embedded with absolute path names which is casuing reproducibiluty
> issues.
> > > > > This change will fix the path name format back to '/rust/$hash' as
> in
> > > > earlier versions.
> > > > >
> > > > > Below are the links for detailed bug description & discusssion with
> > > > upstream rust.
> > > > >
> https://github.com/rust-lang/rust/issues/120825#issuecomment-1964307219
> > > > >
> https://github.com/rust-lang/rust/issues/120825#issuecomment-1964652656
> > > > >
> > > > > Signed-off-by: Sundeep KOKKONDA <sundeep.kokkonda@windriver.com>
> > > > > Signed-off-by: Yash Shinde <Yash.Shinde@windriver.com>
> > > > > Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
> > > > > Signed-off-by: Jose Quaresma <jose.quaresma@foundries.io>
> > > > > ---
> > > > > .../files/repro-issue-fix-with-v175.patch | 23
> +++++++++++++++++++
> > > > > recipes-devtools/rust/rust-source.inc | 1 +
> > > > > 2 files changed, 24 insertions(+)
> > > > > create mode 100644
> > > > recipes-devtools/rust/files/repro-issue-fix-with-v175.patch
> > > > >
> > > > > diff --git
> a/recipes-devtools/rust/files/repro-issue-fix-with-v175.patch
> > > > b/recipes-devtools/rust/files/repro-issue-fix-with-v175.patch
> > > > > new file mode 100644
> > > > > index 0000000..6840baf
> > > > > --- /dev/null
> > > > > +++ b/recipes-devtools/rust/files/repro-issue-fix-with-v175.patch
> > > > > @@ -0,0 +1,23 @@
> > > > > +rust: reproducibility issue fix with v1.75
> > > > > +
> > > > > +With 1.75 rust release, the '.rustc' section of shared object
> libs are
> > > > embedded with absolute path names which is casuing reproducibiluty
> issues.
> > > > > +This change will fix the path name format back to '/rust/$hash'
> as in
> > > > earlier versions.
> > > > > +
> > > > > +Below are the links for detailed bug description & discusssion
> with
> > > > upstream rust.
> > > > > +
> https://github.com/rust-lang/rust/issues/120825#issuecomment-1964307219
> > > > > +
> https://github.com/rust-lang/rust/issues/120825#issuecomment-1964652656
> > > > > +
> > > > > +Upstream-Status: Inappropriate [patches need rework]
> > > > > +Signed-off-by: Sundeep KOKKONDA <sundeep.kokkonda@windriver.com>
> > > > > +---
> > > > > +--- a/compiler/rustc_session/src/session.rs 2023-12-21
> > > > 08:55:28.000000000 -0800
> > > > > ++++ b/compiler/rustc_session/src/session.rs 2024-02-26
> > > > 07:29:15.527577022 -0800
> > > > > +@@ -1269,7 +1269,7 @@
> > > > > + | CrateType::Rlib
> > > > > + | CrateType::Staticlib
> > > > > + | CrateType::Cdylib => continue,
> > > > > +- CrateType::ProcMacro => return false,
> > > > > ++ CrateType::ProcMacro => return true,
> > > > > + }
> > > > > + }
> > > > > +
> > > > > diff --git a/recipes-devtools/rust/rust-source.inc
> > > > b/recipes-devtools/rust/rust-source.inc
> > > > > index 8ae8add..6bef990 100644
> > > > > --- a/recipes-devtools/rust/rust-source.inc
> > > > > +++ b/recipes-devtools/rust/rust-source.inc
> > > > > @@ -12,6 +12,7 @@ SRC_URI += "
> > > > https://static.rust-lang.org/dist/rustc-${RUST_VERSION}-src.tar.xz;n
> > > > > file://rustc-bootstrap.patch;patchdir=${RUSTSRC} \
> > > > > file://target-build-value.patch;patchdir=${RUSTSRC} \
> > > > >
> > > >
> file://0001-Handle-vendored-sources-when-remapping-paths.patch;patchdir=${RUSTSRC}
> > > > \
> > > > > +
> file://repro-issue-fix-with-v175.patch;patchdir=${RUSTSRC} \
> > > > > "
> > > > > SRC_URI[rust.sha256sum] =
> > > > "4526f786d673e4859ff2afa0bab2ba13c918b796519a25c1acce06dba9542340"
> > > > >
> > > > > --
> > > > > 2.44.0
> > > > >
> > > >
> > >
> > >
> > >
--
Best regards,
José Quaresma
[-- Attachment #2: Type: text/html, Size: 8952 bytes --]
next prev parent reply other threads:[~2024-03-18 10:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-11 16:24 [meta-lts-mixins][kirkstone/rust][PATCH 01/11] rust: Fetch cargo from rust-snapshot dir Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 02/11] rust: detect user-specified custom targets in compiletest Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 03/11] rust: Enable RUSTC_BOOTSTRAP to use nightly features during rust oe-selftest Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 04/11] rust: Fix assertion failure error on oe-selftest Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 05/11] rust: Enable rust oe-selftest Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 06/11] rust: Re-write RPATHs in the copies llvm-config Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 07/11] rust/cargo: Build fixes to rust for rv32 target Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 08/11] rust: Upgrade 1.74.1 -> 1.75.0 Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 09/11] rust: Revert PGO to it's default Jose Quaresma
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 10/11] rust: reproducibility issue fix with v1.75 Jose Quaresma
[not found] ` <bfbd5a23-720d-410b-a359-56c1822a0cf6@windriver.com>
2024-03-12 12:46 ` Jose Quaresma
2024-03-12 20:34 ` Scott Murray
2024-03-18 0:10 ` Scott Murray
2024-03-18 10:03 ` Jose Quaresma [this message]
2024-03-11 16:24 ` [meta-lts-mixins][kirkstone/rust][PATCH 11/11] rust: Fix build failure re-appeared on riscv32 Jose Quaresma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANPvuRnKNiAqF4DWw34+CbrW9YyfChJDLQrD8vR3_rZisonnSg@mail.gmail.com \
--to=quaresma.jose@gmail.com \
--cc=Sundeep.Kokkonda@windriver.com \
--cc=Yash.Shinde@windriver.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=scott.murray@konsulko.com \
--cc=yocto@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).