* [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e
@ 2024-01-24 17:51 Trevor Woerner
2024-01-24 17:56 ` [yocto] " Quentin Schulz
0 siblings, 1 reply; 3+ messages in thread
From: Trevor Woerner @ 2024-01-24 17:51 UTC (permalink / raw
To: yocto
The U-Boot patches that were added recently are only for the rock-pi-e
MACHINE, therefore only apply them when building for rock-pi-e.
Fixes: b5bba3a01197 ("rock-pi-e: apply upstream PHY fix")
Signed-off-by: Trevor Woerner <twoerner@gmail.com>
---
recipes-bsp/u-boot/u-boot%.bbappend | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/recipes-bsp/u-boot/u-boot%.bbappend b/recipes-bsp/u-boot/u-boot%.bbappend
index 292530c5ad40..f8378d91ce68 100644
--- a/recipes-bsp/u-boot/u-boot%.bbappend
+++ b/recipes-bsp/u-boot/u-boot%.bbappend
@@ -1,5 +1,5 @@
FILESEXTRAPATHS:prepend := "${THISDIR}/files:"
-SRC_URI += " \
+SRC_URI:append:rock-pi-e = " \
file://PATCH_1-2_net_designware_Reset_eth_phy_before_phy_connect.patch \
file://PATCH_2-2_rockchip_rk3328-rock-pi-e_Enable_DM_ETH_PHY_and_PHY_REALTEK.patch \
"
--
2.43.0.76.g1a87c842ece3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [yocto] [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e
2024-01-24 17:51 [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e Trevor Woerner
@ 2024-01-24 17:56 ` Quentin Schulz
2024-01-24 18:21 ` Trevor Woerner
0 siblings, 1 reply; 3+ messages in thread
From: Quentin Schulz @ 2024-01-24 17:56 UTC (permalink / raw
To: yocto, twoerner
Hi Trevor,
On 1/24/24 18:51, Trevor Woerner via lists.yoctoproject.org wrote:
> The U-Boot patches that were added recently are only for the rock-pi-e
> MACHINE, therefore only apply them when building for rock-pi-e.
>
> Fixes: b5bba3a01197 ("rock-pi-e: apply upstream PHY fix")
> Signed-off-by: Trevor Woerner <twoerner@gmail.com>
Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>
What a nice timing, got "bothered" by this a few hours ago but got
sidetracked :)
I **think** this would make more sense in a u-boot_2024.01.bbappend
though, since it'll likely only apply on top of that version :)
Cheers,
Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [yocto] [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e
2024-01-24 17:56 ` [yocto] " Quentin Schulz
@ 2024-01-24 18:21 ` Trevor Woerner
0 siblings, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2024-01-24 18:21 UTC (permalink / raw
To: Quentin Schulz; +Cc: yocto
On Wed 2024-01-24 @ 06:56:01 PM, Quentin Schulz wrote:
> Hi Trevor,
>
> On 1/24/24 18:51, Trevor Woerner via lists.yoctoproject.org wrote:
> > The U-Boot patches that were added recently are only for the rock-pi-e
> > MACHINE, therefore only apply them when building for rock-pi-e.
> >
> > Fixes: b5bba3a01197 ("rock-pi-e: apply upstream PHY fix")
> > Signed-off-by: Trevor Woerner <twoerner@gmail.com>
>
> Reviewed-by: Quentin Schulz <foss+yocto@0leil.net>
>
> What a nice timing, got "bothered" by this a few hours ago but got
> sidetracked :)
>
> I **think** this would make more sense in a u-boot_2024.01.bbappend though,
> since it'll likely only apply on top of that version :)
Hopefully these patches go upstream soon, when it does my nightly build will
fail, and I can remove it the next day. But if the patches don't get into the
next release then rock-pi-e's second ethernet will stop working again if we
make it version-specific.
> Cheers,
> Quentin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-01-24 18:21 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-24 17:51 [meta-rockchip][PATCH] u-boot: make rock-pi-e patches only for rock-pi-e Trevor Woerner
2024-01-24 17:56 ` [yocto] " Quentin Schulz
2024-01-24 18:21 ` Trevor Woerner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).