From: Tim Orling <ticotimo@gmail.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: bitbake-devel@lists.openembedded.org,
toaster@lists.yoctoproject.org,
Tim Orling <tim.orling@konsulko.com>
Subject: Re: [Toaster] [PATCH] toaster: log ProcessLookupError in test_runbuilds
Date: Fri, 10 Nov 2023 11:16:55 -0800 [thread overview]
Message-ID: <CANx9H-Cx-j=kcSOppNiA_B52By0ze9KF8Yi4yGV_b-gjvwC=PQ@mail.gmail.com> (raw)
In-Reply-To: <85003f99a53c415511aa2c3efa54a32ee1303e13.camel@linuxfoundation.org>
[-- Attachment #1: Type: text/plain, Size: 2372 bytes --]
Ignore this patch. More analysis is required.
On Fri, Nov 10, 2023 at 10:01 AM Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:
> On Fri, 2023-11-10 at 07:30 -0800, Tim Orling wrote:
> > This repeatably fails:
> >
> > Exception in thread Thread-2:
> > Traceback (most recent call last):
> > File "/usr/lib/python3.10/threading.py", line 1016, in _bootstrap_inner
> > self.run()
> > File ".../poky/bitbake/lib/toaster/tests/commands/test_runbuilds.py",
> line 39, in run
> > os.kill(int(pid), signal.SIGTERM)
> > ProcessLookupError: [Errno 3] No such process
> >
> > Rather than have a hard error, add logging and output as a warning.
> >
> > Signed-off-by: Tim Orling <tim.orling@konsulko.com>
> > ---
> > lib/toaster/tests/commands/test_runbuilds.py | 11 +++++++++--
> > 1 file changed, 9 insertions(+), 2 deletions(-)
> >
> > diff --git a/lib/toaster/tests/commands/test_runbuilds.py
> b/lib/toaster/tests/commands/test_runbuilds.py
> > index c77d6cf4..14b35764 100644
> > --- a/lib/toaster/tests/commands/test_runbuilds.py
> > +++ b/lib/toaster/tests/commands/test_runbuilds.py
> > @@ -19,6 +19,10 @@ import time
> > import subprocess
> > import signal
> >
> > +import logging
> > +
> > +logger = logging.getLogger("toaster")
> > +
> >
> > class KillRunbuilds(threading.Thread):
> > """ Kill the runbuilds process after an amount of time """
> > @@ -36,8 +40,11 @@ class KillRunbuilds(threading.Thread):
> >
> > with open(pidfile_path) as pidfile:
> > pid = pidfile.read()
> > - os.kill(int(pid), signal.SIGTERM)
> > -
> > + try:
> > + os.kill(int(pid), signal.SIGTERM)
> > + except ProcessLookupError as err:
> > + logger.warning("Failed to kill pid. %s" % err)
> > + pass
> >
>
> Is this a case of "just ensure bitbake has really exited"? If so we
> perhaps don't need the warning as it is quite likely it has exited?
>
>
When Toaster starts, the .runbuild.pid file is created in the $BUILDDIR.
Manually running 'manage.py runbuilds' should leave a process running.
My suspicion is the path to .runbuilds.pid is somehow getting mangled or
a stale, old .runbuilds.pid is sticking around. Something is wonky in the
test environment.
> Cheers,
>
> Richard
>
>
[-- Attachment #2: Type: text/html, Size: 3378 bytes --]
prev parent reply other threads:[~2023-11-10 19:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-10 15:30 [PATCH] toaster: log ProcessLookupError in test_runbuilds Tim Orling
2023-11-10 18:01 ` [Toaster] " Richard Purdie
2023-11-10 19:16 ` Tim Orling [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANx9H-Cx-j=kcSOppNiA_B52By0ze9KF8Yi4yGV_b-gjvwC=PQ@mail.gmail.com' \
--to=ticotimo@gmail.com \
--cc=bitbake-devel@lists.openembedded.org \
--cc=richard.purdie@linuxfoundation.org \
--cc=tim.orling@konsulko.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).