From: Tim Orling <ticotimo@gmail.com>
To: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
Cc: toaster@lists.yoctoproject.org
Subject: Re: [Toaster] [PATCH 2/3] Toaster: Test documentation link in landing header is displayed
Date: Tue, 31 Oct 2023 08:30:22 -0700 [thread overview]
Message-ID: <CANx9H-A5WT3HfmHv4+5p25pGAbwAym1P0JKa94sY3qr-W_PJ=w@mail.gmail.com> (raw)
In-Reply-To: <20231030222513.403014-2-alassane.yattara@savoirfairelinux.com>
[-- Attachment #1: Type: text/plain, Size: 2374 bytes --]
On Mon, Oct 30, 2023 at 3:25 PM Alassane Yattara <
alassane.yattara@savoirfairelinux.com> wrote:
> - check that the documentation link is visible
> - check browser open new tab toaster manual when clicking on the
> documentation link
>
> The test case seems reasonable and the explanation is sufficient.
> Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
>
Reviewed-by: Tim Orling <tim.orling@konsulko.com>
> ---
> lib/toaster/tests/browser/test_landing_page.py | 15 +++++++++++++++
> 1 file changed, 15 insertions(+)
>
> diff --git a/lib/toaster/tests/browser/test_landing_page.py
> b/lib/toaster/tests/browser/test_landing_page.py
> index 2f092400..e731af22 100644
> --- a/lib/toaster/tests/browser/test_landing_page.py
> +++ b/lib/toaster/tests/browser/test_landing_page.py
> @@ -46,6 +46,21 @@ class TestLandingPage(SeleniumTestCase):
> self.assertTrue(info_modal.is_displayed())
> self.assertTrue("Toaster version information" in info_modal.text)
>
> + def test_documentation_link_displayed(self):
> + """ Test that the documentation link is displayed """
> + self.get(reverse('landing'))
> + documentation_link = self.find('#navbar-docs > a')
> +
> + # check that the documentation link is visible
> + self.assertTrue(documentation_link.is_displayed())
> +
> + # check browser open new tab toaster manual when clicking on the
> documentation link
> + self.assertEqual(documentation_link.get_attribute('target') ,
> '_blank')
> + self.assertEqual(
> + documentation_link.get_attribute('href'),
> + '
> http://docs.yoctoproject.org/toaster-manual/index.html#toaster-user-manual
> ')
> + self.assertTrue("Documentation" in documentation_link.text)
> +
> def test_only_default_project(self):
> """
> No projects except default
> --
> 2.34.1
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#5913):
> https://lists.yoctoproject.org/g/toaster/message/5913
> Mute This Topic: https://lists.yoctoproject.org/mt/102286634/924729
> Group Owner: toaster+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [
> ticotimo@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
>
[-- Attachment #2: Type: text/html, Size: 3936 bytes --]
next prev parent reply other threads:[~2023-10-31 15:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-30 22:25 [PATCH 1/3] Toaster: Check info_sign is visible and clickable in landing page Alassane Yattara
2023-10-30 22:25 ` [PATCH 2/3] Toaster: Test documentation link in landing header is displayed Alassane Yattara
2023-10-31 15:30 ` Tim Orling [this message]
2023-10-30 22:25 ` [PATCH 3/3] Toaster: Test jumbotron links visible and clickable Alassane Yattara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CANx9H-A5WT3HfmHv4+5p25pGAbwAym1P0JKa94sY3qr-W_PJ=w@mail.gmail.com' \
--to=ticotimo@gmail.com \
--cc=alassane.yattara@savoirfairelinux.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).