From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Marlon Rodriguez Garcia
<marlon.rodriguez-garcia@savoirfairelinux.com>,
bitbake-devel@lists.openembedded.org
Cc: "toaster@lists.yoctoproject.org" <toaster@lists.yoctoproject.org>
Subject: Re: [bitbake-devel] [PATCH 1/1] toaster:update selenium version and code syntax
Date: Tue, 03 Oct 2023 22:56:03 +0100 [thread overview]
Message-ID: <7901b68485c9e4a718865d07b6e0ce194366b042.camel@linuxfoundation.org> (raw)
In-Reply-To: <20231003172623.72071-1-marlon.rodriguez-garcia@savoirfairelinux.com>
On Tue, 2023-10-03 at 13:26 -0400, Marlon Rodriguez Garcia wrote:
> Updated selenium version to latest 4.13.0, changed selenum specific version syntax elements to accomplish test success
>
> Signed-off-by: Marlon Rodriguez Garcia <marlon.rodriguez-garcia@savoirfairelinux.com>
> ---
> lib/toaster/orm/models.py | 2 +-
> .../tests/browser/selenium_helpers_base.py | 9 +-
> .../tests/browser/test_all_builds_page.py | 26 ++--
> .../tests/browser/test_all_projects_page.py | 14 +-
> .../tests/browser/test_builddashboard_page.py | 10 +-
> .../browser/test_most_recent_builds_states.py | 12 +-
> .../browser/test_new_custom_image_page.py | 4 +
> .../tests/browser/test_new_project_page.py | 12 +-
> .../tests/browser/test_project_config_page.py | 29 +++--
> .../tests/browser/test_toastertable_ui.py | 7 +-
> .../tests/builds/test_core_image_min.py | 1 +
> .../tests/functional/functional_helpers.py | 21 +--
> .../tests/functional/test_functional_basic.py | 120 +++++++++---------
> .../tests/toaster-tests-requirements.txt | 2 +-
> lib/toaster/tests/views/test_views.py | 4 +
> lib/toaster/toastergui/widgets.py | 1 +
> 16 files changed, 156 insertions(+), 118 deletions(-)
At a quick glance this seems reasonable to me but I'm far from an
expert in this area. I've realised that for toaster patches you should
copy the toaster mailing list as well. I'll likely wait a short while
for feedback then merge if there isn't any. At this point our automated
testing won't cover anything here but I know we plan to change that!
Cheers,
Richard
next parent reply other threads:[~2023-10-03 21:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20231003172623.72071-1-marlon.rodriguez-garcia@savoirfairelinux.com>
2023-10-03 21:56 ` Richard Purdie [this message]
2023-10-12 4:00 ` [bitbake-devel] [PATCH 1/1] toaster:update selenium version and code syntax Reyna, David
2023-10-12 14:04 ` Marlon Rodriguez Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7901b68485c9e4a718865d07b6e0ce194366b042.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=bitbake-devel@lists.openembedded.org \
--cc=marlon.rodriguez-garcia@savoirfairelinux.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).