From: "Marlon Rodriguez Garcia" <marlon.rodriguez-garcia@savoirfairelinux.com>
To: toaster@lists.yoctoproject.org
Subject: Re: Toaster test documentation
Date: Thu, 19 Oct 2023 07:24:02 -0700 [thread overview]
Message-ID: <6763.1697725442004007297@lists.yoctoproject.org> (raw)
In-Reply-To: <CANx9H-Dc7Lh++7ak4jAVhCzEnQRi6PyteP-BLPp1u_RbQM6vWQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 2840 bytes --]
Hello
I will try to answer all the question, no sure if this wil be include in both channels.
*So, in the bitbake environment in which Toaster must be run, how are you using tox?*
A: Tox is added locally so far to run the set of instructions, installed locally as a python library, the tox.ini file will be located inside toaster and all the validation will be only target at toaster, not bitbake as a whole
*Is it bringing us benefit over just running the test tools themselves?*
A: The benefits of using tox are the same for which the tool was created, to automate and standardize testing, i am not entirely sure of the implications of adding a new library such as tox to the openembedded project, but from a python developer perspective with tox we can simplified the execution of the test
*Are we certain we want the opinionated results from flake8?
* A: The inclusion of flake8 as a tool to validate the source code came from a perspective as a python developer, to standardize the source code into the PEP8 guide. This is the topic we have been discussing with Richard and that requires the community validation because it will be needed to modify most if not all the files in toaster to accomplish the flake8 rules, https://www.flake8rules.com/. We need the community feedback on this.
*Does anything else in bitbake pass those tests?
* A: We are only focusing in the toaster lib, if integrated flake8 will only be used on toaster python files.
*Since this tells us to ` pip3 install selenium==2.53.2` we already know it cannot possibly be what is being done to run the tests. So what else is wrong in those steps?
* A: In order to reproduce the test we have been using the README files available inside the toaster library, this are the steps we are following to do so :
1 - We are using poky as the global project to execute all the changes
2 - The requirements needed to run toaster and the toaster test suite are located on the files https://git.openembedded.org/bitbake/tree/toaster-requirements.txt and https://git.openembedded.org/bitbake/tree/lib/toaster/tests/toaster-tests-requirements.txt.
3 - After executing the command *source oe-init-build-env* from the poky directory we are redirected to */poky/build*
4 - We can execute the following command to run the test on toaster : *EVENTREPLAY_DIR=./ TOASTER_BUILDSERVER=1 DJANGO_SETTINGS_MODULE=toastermain.settings_test ../bitbake/lib/toaster/manage.py test tests.db tests.commands tests.builds tests.browser tests.functional tests.views*
5 - If we execute the command from another path, the global parameters must be adjusted. This is one of the elements that can be accomplish by using tox and having all elements already define for any user.
Please let us know if this answer your questions or we need to provide more information
Thanks
[-- Attachment #2: Type: text/html, Size: 3523 bytes --]
prev parent reply other threads:[~2023-10-19 14:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-18 22:09 Toaster test documentation Tim Orling
2023-10-19 14:24 ` Marlon Rodriguez Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6763.1697725442004007297@lists.yoctoproject.org \
--to=marlon.rodriguez-garcia@savoirfairelinux.com \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).