From: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
To: Richard Purdie <richard.purdie@linuxfoundation.org>
Cc: toaster <toaster@lists.yoctoproject.org>
Subject: Re: [Toaster] [PATCH v2 3/3] Toaster: Write UI TestCase import new project using
Date: Thu, 9 Nov 2023 17:18:08 -0500 (EST) [thread overview]
Message-ID: <1623693830.585694.1699568288037.JavaMail.zimbra@savoirfairelinux.com> (raw)
In-Reply-To: <9c199140956897c2424bf866cb40f1084164f609.camel@linuxfoundation.org>
Richard,
Yes you right below line should be remove from commit msg.
> * Update copyright, remove "Inc"
----- Mail original -----
De: "Richard Purdie" <richard.purdie@linuxfoundation.org>
À: "Alassane Yattara" <alassane.yattara@savoirfairelinux.com>, "toaster" <toaster@lists.yoctoproject.org>
Envoyé: Jeudi 9 Novembre 2023 23:06:28
Objet: Re: [Toaster] [PATCH v2 3/3] Toaster: Write UI TestCase import new project using
On Thu, 2023-11-09 at 22:55 +0100, Alassane Yattara wrote:
> * Test import new project using:
> - Project Name: Any string
> - Project type: select (Import command line project)
> - Import existing project directory: Wrong Path
> * Update copyright, remove "Inc"
This patch series looks *much* better in general, thanks!
I was a little bit puzzled by this last line item about copyright?
Cheers,
Richard
>
> Signed-off-by: Alassane Yattara <alassane.yattara@savoirfairelinux.com>
> ---
> .../functional/test_create_new_project.py | 25 +++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/lib/toaster/tests/functional/test_create_new_project.py b/lib/toaster/tests/functional/test_create_new_project.py
> index f33eb16d..a211d8b7 100644
> --- a/lib/toaster/tests/functional/test_create_new_project.py
> +++ b/lib/toaster/tests/functional/test_create_new_project.py
> @@ -149,3 +149,28 @@ class TestCreateNewProject(SeleniumFunctionalTestCase):
> create_btn = self.driver.find_element(By.ID, "create-project-button")
> self.assertIsNotNone(create_btn.get_attribute('disabled'),
> 'Create button is not disabled')
> +
> + def test_import_new_project(self):
> + """ Test import new project using:
> + - Project Name: Any string
> + - Project type: select (Import command line project)
> + - Import existing project directory: Wrong Path
> + """
> + project_name = 'projectimport'
> + self.get(reverse('newproject'))
> + self.driver.find_element(By.ID,
> + "new-project-name").send_keys(project_name)
> + # select import project
> + self.find('#type-import').click()
> +
> + # set wrong path
> + wrong_path = '/wrongpath'
> + self.driver.find_element(By.ID,
> + "import-project-dir").send_keys(wrong_path)
> + self.driver.find_element(By.ID, "create-project-button").click()
> +
> + # check error message
> + self.assertTrue(self.element_exists('.alert-danger'),
> + 'Allert message not shown')
> + self.assertTrue(wrong_path in self.find('.alert-danger').text,
> + "Wrong path not in alert message")
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#5976): https://lists.yoctoproject.org/g/toaster/message/5976
> Mute This Topic: https://lists.yoctoproject.org/mt/102495675/1686473
> Group Owner: toaster+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/toaster/unsub [richard.purdie@linuxfoundation.org]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2023-11-09 22:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-09 21:55 [PATCH v2 1/3] Toaster: Write UI TestCase create new project Alassane Yattara
2023-11-09 21:55 ` [PATCH v2 2/3] Toaster: Test create new project without project name Alassane Yattara
2023-11-09 21:55 ` [PATCH v2 3/3] Toaster: Write UI TestCase import new project using Alassane Yattara
2023-11-09 22:06 ` [Toaster] " Richard Purdie
2023-11-09 22:18 ` Alassane Yattara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623693830.585694.1699568288037.JavaMail.zimbra@savoirfairelinux.com \
--to=alassane.yattara@savoirfairelinux.com \
--cc=richard.purdie@linuxfoundation.org \
--cc=toaster@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).