From: Awais Belal <awais_belal@mentor.com>
To: <toaster@yoctoproject.org>
Subject: [sumo][PATCH 8/8] toaster/layerdetails.js: don't hide local layer info
Date: Fri, 6 Jul 2018 15:43:59 +0500 [thread overview]
Message-ID: <1530873839-4445-8-git-send-email-awais_belal@mentor.com> (raw)
In-Reply-To: <1530873839-4445-1-git-send-email-awais_belal@mentor.com>
The local layer info (provided through custom fixtures) should
not be hidden and it is better to handle it in the same manner
as an imported layer otherwise the layer path and dependency
info is not shown. The layer editing fields are handled in the
html side of things appropriately so this does not harm that
implementation.
Signed-off-by: Awais Belal <awais_belal@mentor.com>
---
bitbake/lib/toaster/toastergui/static/js/layerdetails.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/bitbake/lib/toaster/toastergui/static/js/layerdetails.js b/bitbake/lib/toaster/toastergui/static/js/layerdetails.js
index 9ead393..933b65b 100644
--- a/bitbake/lib/toaster/toastergui/static/js/layerdetails.js
+++ b/bitbake/lib/toaster/toastergui/static/js/layerdetails.js
@@ -359,7 +359,8 @@ function layerDetailsPageInit (ctx) {
if ($(this).is("dt")) {
var dd = $(this).next("dd");
if (!dd.children("form:visible")|| !dd.find(".current-value").html()){
- if (ctx.layerVersion.layer_source == ctx.layerSourceTypes.TYPE_IMPORTED){
+ if (ctx.layerVersion.layer_source == ctx.layerSourceTypes.TYPE_IMPORTED ||
+ ctx.layerVersion.layer_source == ctx.layerSourceTypes.TYPE_LOCAL) {
/* There's no current value and the layer is editable
* so show the "Not set" and hide the delete icon
*/
--
2.7.4
prev parent reply other threads:[~2018-07-06 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-06 10:43 [sumo][PATCH 1/8] toaster: allow pokydirname to be evaluated when all layers are local Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 2/8] toaster: use a more flexible way to find bitbake Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 3/8] toaster: allow TOASTER_DIR to be overridden from cmdline Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 4/8] toaster/widgets.py: avoid divide by zero issues Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 5/8] toastergui/newproject.html: fix release divs Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 6/8] toaster/checksettings: allow CUSTOM_XML_ONLY setting through env Awais Belal
2018-07-06 10:43 ` [sumo][PATCH 7/8] toaster/models.py: allow local paths for custom recipe's base Awais Belal
2018-07-06 10:43 ` Awais Belal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1530873839-4445-8-git-send-email-awais_belal@mentor.com \
--to=awais_belal@mentor.com \
--cc=toaster@yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).