From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: patrick.wicki@subset.ch
Cc: meta-virtualization@lists.yoctoproject.org,
Patrick Wicki <patrick.wicki@siemens.com>
Subject: Re: [meta-virtualization][PATCH 1/2] podman: remove skopeo rdepends
Date: Thu, 2 May 2024 17:56:44 +0000 [thread overview]
Message-ID: <ZjPT3GyNRMsCJoxi@gmail.com> (raw)
In-Reply-To: <20240429172523.1635019-1-patrick.wicki@subset.ch>
Hi Patrick,
In message: [meta-virtualization][PATCH 1/2] podman: remove skopeo rdepends
on 29/04/2024 Patrick Wicki via lists.yoctoproject.org wrote:
> From: Patrick Wicki <patrick.wicki@siemens.com>
>
> Podman does not require skopeo to run. They are both independent tools.
> In distros like Debian, Fedora and Arch they don't depend on it either.
>
> We do require some of its dependencies, so include those directly.
> Skopeo also seems to be used in some of podman's tests, so it makes
> sense to keep it around for the ptest.
>
> Signed-off-by: Patrick Wicki <patrick.wicki@siemens.com>
> ---
> recipes-containers/podman/podman_git.bb | 11 +++++++++--
> 1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/recipes-containers/podman/podman_git.bb b/recipes-containers/podman/podman_git.bb
> index f69dec16..41f090f0 100644
> --- a/recipes-containers/podman/podman_git.bb
> +++ b/recipes-containers/podman/podman_git.bb
> @@ -55,6 +55,7 @@ TOOLCHAIN = "gcc"
> export BUILDFLAGS="${GOBUILDFLAGS}"
>
> inherit go goarch
> +inherit container-host
The addition of container-host configuration should be mentioned
in the commit log.
> inherit systemd pkgconfig ptest
>
> do_configure[noexec] = "1"
> @@ -148,8 +149,13 @@ VIRTUAL-RUNTIME_base-utils-nsenter ?= "util-linux-nsenter"
>
> COMPATIBLE_HOST = "^(?!mips).*"
>
> -RDEPENDS:${PN} += "\
> - conmon ${VIRTUAL-RUNTIME_container_runtime} iptables ${VIRTUAL-RUNTIME_container_networking} skopeo ${VIRTUAL-RUNTIME_base-utils-nsenter} \
> +RDEPENDS:${PN} += " \
> + conmon \
> + iptables \
> + libdevmapper \
> + ${VIRTUAL-RUNTIME_base-utils-nsenter} \
> + ${VIRTUAL-RUNTIME_container_networking} \
> + ${VIRTUAL-RUNTIME_container_runtime} \
> ${@bb.utils.contains('PACKAGECONFIG', 'rootless', 'fuse-overlayfs slirp4netns', '', d)} \
Many people know that I don't like mixing formatting and functional
changes. So in a v2, keep the formatting as is and make the change
without sorting or changing the list of rdepends.
Other than that, I agree with the logic of the change and thanks
for the patch!
Bruce
> "
> RRECOMMENDS:${PN} += "slirp4netns \
> @@ -172,5 +178,6 @@ RDEPENDS:${PN}-ptest += " \
> gnupg \
> jq \
> make \
> + skopeo \
> tar \
> "
> --
> 2.44.0
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#8704): https://lists.yoctoproject.org/g/meta-virtualization/message/8704
> Mute This Topic: https://lists.yoctoproject.org/mt/105805579/1050810
> Group Owner: meta-virtualization+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/meta-virtualization/unsub [bruce.ashfield@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
prev parent reply other threads:[~2024-05-02 17:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 17:25 [meta-virtualization][PATCH 1/2] podman: remove skopeo rdepends patrick.wicki
2024-04-29 17:25 ` [meta-virtualization][PATCH 2/2] podman: require catatonit patrick.wicki
2024-05-02 17:58 ` Bruce Ashfield
2024-05-02 17:56 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjPT3GyNRMsCJoxi@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
--cc=patrick.wicki@siemens.com \
--cc=patrick.wicki@subset.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).