From: Bruce Ashfield <bruce.ashfield@gmail.com>
To: Martin Jansa <martin.jansa@gmail.com>
Cc: meta-virtualization@lists.yoctoproject.org,
Chen Qi <Qi.Chen@windriver.com>
Subject: Re: [mickledore][PATCH] cni: fix textrel QA issue
Date: Tue, 11 Jul 2023 19:06:48 +0000 [thread overview]
Message-ID: <ZK2oSGXaRX8roo9F@gmail.com> (raw)
In-Reply-To: <20230707084424.2476021-1-Martin.Jansa@gmail.com>
In message: [mickledore][PATCH] cni: fix textrel QA issue
on 07/07/2023 Martin Jansa wrote:
> From: Chen Qi <Qi.Chen@windriver.com>
>
> When building cni, we get textrel QA issue like below:
>
> cni: ELF binary /usr/libexec/cni/macvlan has relocations in .text
>
> The problem could be solved by adding '-buildmode=pie' to ${GO}.
>
> In go.bbclass, this flag is added to GOBUILDFLAGS conditionally,
> that is, if the arch is not mips nor riscv32, this '-buildmode=pie'
> is added to GOBUILDFLAGS. So make use of that.
merged.
Bruce
>
> Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
> Signed-off-by: Bruce Ashfield <bruce.ashfield@gmail.com>
> ---
> recipes-networking/cni/cni_git.bb | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/recipes-networking/cni/cni_git.bb b/recipes-networking/cni/cni_git.bb
> index 35aea39..06cef81 100644
> --- a/recipes-networking/cni/cni_git.bb
> +++ b/recipes-networking/cni/cni_git.bb
> @@ -38,10 +38,10 @@ do_compile() {
> export GO111MODULE=off
>
> cd ${B}/src/github.com/containernetworking/cni/libcni
> - ${GO} build -trimpath
> + ${GO} build ${GOBUILDFLAGS}
>
> cd ${B}/src/github.com/containernetworking/cni/cnitool
> - ${GO} build -trimpath
> + ${GO} build ${GOBUILDFLAGS}
>
> cd ${B}/src/github.com/containernetworking/plugins
> PLUGINS="$(ls -d plugins/meta/*; ls -d plugins/ipam/*; ls -d plugins/main/* | grep -v windows)"
> @@ -49,7 +49,7 @@ do_compile() {
> for p in $PLUGINS; do
> plugin="$(basename "$p")"
> echo "building: $p"
> - ${GO} build -trimpath -o ${B}/plugins/bin/$plugin github.com/containernetworking/plugins/$p
> + ${GO} build ${GOBUILDFLAGS} -o ${B}/plugins/bin/$plugin github.com/containernetworking/plugins/$p
> done
> }
>
> --
> 2.41.0
>
prev parent reply other threads:[~2023-07-11 19:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-07 8:44 [mickledore][PATCH] cni: fix textrel QA issue Martin Jansa
2023-07-11 19:06 ` Bruce Ashfield [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZK2oSGXaRX8roo9F@gmail.com \
--to=bruce.ashfield@gmail.com \
--cc=Qi.Chen@windriver.com \
--cc=martin.jansa@gmail.com \
--cc=meta-virtualization@lists.yoctoproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).